From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3971 invoked by alias); 28 Apr 2017 14:53:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3429 invoked by uid 89); 28 Apr 2017 14:53:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=management X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 14:53:43 +0000 Received: by mail-wm0-f44.google.com with SMTP id u65so44464548wmu.1 for ; Fri, 28 Apr 2017 07:53:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=URaOgmP1hoLLI/2jq1orYmgqpiBpgZs11TUtYTk6GaU=; b=CqPiUIlgAIxSAXrcW8etKIRhtjnKjnCgiSUM9HxhWG3bknjloGrcZKBD1LxLcKbYb8 W5p9xdLgWVm6UxLRzVEYx4GJNozRopcNa4y16kysj3Hav56TcrHgaup5sWsvnyqUvLM6 JsFi52QzBp4uMs1T51OpDmvvXbGpp3q6x8MS+FVs+0niUOP9gMtUPvzdJBLQHeIclFCh EWL06N7Qrg/xydgxYm+6mrbzPOEQqasHHGmXt/CT/yPpI8yAlyFNaYdDdOf4C+CuYoHy WwuhaVC6293uHERxKUYS8igKkTb3X+nG2Tx8Eja+vEQKI6LkV349DIEabQoYUAsyY+SH G3Ew== X-Gm-Message-State: AN3rC/4uJ+YD1m4C0xEwg/cO4B9qWdrD8DKJiNBnCLQoYKqWKSpDtv2p pG5rnAzNeG0kfYAr X-Received: by 10.28.178.17 with SMTP id b17mr5790342wmf.23.1493391223737; Fri, 28 Apr 2017 07:53:43 -0700 (PDT) Received: from ?IPv6:2a02:c7f:ae15:7800:4685:ff:fe66:9f4? ([2a02:c7f:ae15:7800:4685:ff:fe66:9f4]) by smtp.gmail.com with ESMTPSA id z14sm2686332wmz.2.2017.04.28.07.53.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 07:53:42 -0700 (PDT) Subject: Re: [RFA 05/10] Avoid manual resource management in py-framefilter.c To: Tom Tromey , gdb-patches@sourceware.org References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-6-tom@tromey.com> From: Phil Muldoon Message-ID: <2f1e5b29-6359-7a77-0d06-c3a96cae54f1@redhat.com> Date: Fri, 28 Apr 2017 14:53:00 -0000 MIME-Version: 1.0 In-Reply-To: <20170425194113.17862-6-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00785.txt.bz2 On 25/04/17 20:41, Tom Tromey wrote: > This patch removes the last bit of manual resource management from > py-framefilter.c. This will be useful in the next patch. > > ChangeLog > 2017-04-25 Tom Tromey > > * python/py-framefilter.c (enumerate_args): Use > gdb::unique_xmalloc_ptr. LGTM (and much cleaner). Thanks for doing this and the original automated resource management and reference counting from previous patches. Cheers Phil