From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by sourceware.org (Postfix) with ESMTPS id B416E3858D3C for ; Mon, 27 Mar 2023 18:06:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B416E3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f52.google.com with SMTP id o32so5536453wms.1 for ; Mon, 27 Mar 2023 11:06:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679940361; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxXTRR2+rU++f/fSuNTu/WDabB51VtkW5inW2BOwF4Q=; b=Y6e/hVxb/GeX/kQUtWpySMUQjTwOpqvlpNxldkb6yljn6eePVC7kuyxe/pNy9IB79O GPD4dkvkdAC7hojZNnlLjkfZTFv/mDz+U1+0Yq5Zc/W79HUmTE4HrLkR1MpVU2/n6rZZ rOmkGnJNNa0eRbwYxtFQKEL35NCV9MIUfQg6AavKmxqI3mBjz8gjbzSEmkMptB5iO6Lj ueZjqz+RSj8cidlX5bLWwScRzw3sWmkIjFJNB0nP3BquQxUjqh6VG5+Y1uqLEaJhf95Z 6yd9aBQODwJGhv4NLL3Xv3NoCY6s39ro9cdfO29gMBwlhNGzlZH/AZP2LKeT/1pTjpCg XwhQ== X-Gm-Message-State: AO0yUKU41hl8xOSfXeb0xs4CrLtHbWX7dQO8YzXQlxifGOE7TkOUc3y9 zrF2+ytETmopt5ok6gF90iHS5p9LGRYatw== X-Google-Smtp-Source: AK7set/pl0jobvXVQ44h58WmLiMMXcLy+MvPmNmmcoGDYEMcpJzvvDTij5lnGcZSQwlLlgXxNymdKg== X-Received: by 2002:a1c:7910:0:b0:3eb:3998:8c05 with SMTP id l16-20020a1c7910000000b003eb39988c05mr9385578wme.6.1679940361111; Mon, 27 Mar 2023 11:06:01 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93c:5900::1fe? ([2001:8a0:f93c:5900::1fe]) by smtp.gmail.com with ESMTPSA id k11-20020a05600c0b4b00b003edef091b17sm14453307wmr.37.2023.03.27.11.06.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 11:06:00 -0700 (PDT) Subject: Re: [PATCH 02/31] linux-nat: introduce pending_status_str To: Andrew Burgess , gdb-patches@sourceware.org References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-3-pedro@palves.net> <87cz6rrma6.fsf@redhat.com> <87wn3gekiq.fsf@redhat.com> From: Pedro Alves Message-ID: <2f55487e-c087-3597-d7be-4cfcf2589964@palves.net> Date: Mon, 27 Mar 2023 19:05:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87wn3gekiq.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-03-16 4:19 p.m., Andrew Burgess wrote: > Pedro Alves writes: >> I tweaked the comments in linux-nat.h in this new version. Let me know what >> you think. >> >> From 10f88baff2e25fb87f37d1665bf283206171dd42 Mon Sep 17 00:00:00 2001 >> From: Pedro Alves >> Date: Fri, 12 Nov 2021 20:50:29 +0000 >> Subject: [PATCH] linux-nat: introduce pending_status_str >> >> I noticed that some debug log output printing an lwp's pending status >> wasn't considering lp->waitstatus. This fixes it, by introducing a >> new pending_status_str function. >> >> Also fix the comment in gdb/linux-nat.h describing >> lwp_info::waitstatus and details the description of lwp_info::status >> while at it. >> >> Change-Id: I66e5c7a363d30a925b093b195d72925ce5b6b980 >> --- >> gdb/linux-nat.c | 19 ++++++++++++++++--- >> gdb/linux-nat.h | 11 +++++++---- >> 2 files changed, 23 insertions(+), 7 deletions(-) > > LGTM. > > Reviewed-By: Andrew Burgess > Thanks, I've merged this one as well, as it's pretty much independent/standalone.