From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 793273858D3C for ; Fri, 6 Oct 2023 07:39:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 793273858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696577946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=usStYzgUZCwk3jP/httSU8ck9NKwL9VtZE+Em8D8tp8=; b=Yc+oAgaMiujPpU+Uqv6YhupEKalzgk0VnG5tWQS4ZXZXLSbZhYM+HK6q/U0lRlJxkRXUr1 g23HUI02JNooxwQC3duXCW/k82YQGJt579f6DUKSUj30qsp/Q9GR+BFJu/X4rppUgIjYDU TQzvpv42Ys2mY8VvlYgfNV8L33+kdkM= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386--sogiK8oNCqV0MHvKuRTzA-1; Fri, 06 Oct 2023 03:39:04 -0400 X-MC-Unique: -sogiK8oNCqV0MHvKuRTzA-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-533d8a785a5so1639445a12.3 for ; Fri, 06 Oct 2023 00:39:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696577943; x=1697182743; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usStYzgUZCwk3jP/httSU8ck9NKwL9VtZE+Em8D8tp8=; b=Iz3jcqnMqoABfqqAdBLQAGPSmYjrDqWXQyro6jdiWTf0LDI0x9XiL5RCW6QlsQym/9 TCyOEKPOK7BweBB0uZrC+vDTdoqmQpSzYv7PWXKCWVZ068VhyUPx/34dEzsrI3snIYxD 4+uv7l8+YsbOEiTgV89QtCqX0NKV12/G57af7+zM0eviqkpev4VamzICPC32jEg3U4ps dnRd8iT8X/yVg6Q0h8FNTFZIHsr5yClw4F8C8JLjluTBSXtLev70v/PAErRkx7tGZ94e VlKXxESX4i3g/RWo0m6iLFS/pI2ehdxcOv3DqJDLhaPlYVP9x84YfRlSElIzIynGxkjb 9Q2Q== X-Gm-Message-State: AOJu0YzPw1qnXZAcUZU2n/cxIuXarpR9pb2ozhIBCbO6apUknXSdLTyX a8k8Jk3/oV+sWQp2H9NHdSAABDrxnTjo/l1gfSoMOSgvSft0oP50Af5B4S+DHAz7EXtwdZs5g/N dfSOJfm/kxZeQsJlJH+RggFNqa/yYVA== X-Received: by 2002:aa7:c507:0:b0:530:5465:ad6d with SMTP id o7-20020aa7c507000000b005305465ad6dmr6597026edq.2.1696577943402; Fri, 06 Oct 2023 00:39:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELLI1neyVc3qr9NhEfKItjY79Vt4RuIPnzpMie0xjbndCxvvvwCGDnonKjv13DolzxElbrFg== X-Received: by 2002:aa7:c507:0:b0:530:5465:ad6d with SMTP id o7-20020aa7c507000000b005305465ad6dmr6597016edq.2.1696577943124; Fri, 06 Oct 2023 00:39:03 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id a23-20020a50ff17000000b005342fa19070sm2149912edu.89.2023.10.06.00.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 00:39:02 -0700 (PDT) Message-ID: <2fc45e96-1d00-076b-0dcd-37c9ca3f87f1@redhat.com> Date: Fri, 6 Oct 2023 09:39:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS To: Eli Zaretskii Cc: gdb-patches@sourceware.org, kevinb@redhat.com References: <20231005113533.86112-2-blarsen@redhat.com> <20231005113533.86112-3-blarsen@redhat.com> <837co13vnz.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <837co13vnz.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/10/2023 18:01, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: eliz@gnu.org, >> Guinevere Larsen , >> Kevin Buettner >> Date: Thu, 5 Oct 2023 13:35:34 +0200 >> >> + - Acked-By: >> + >> + Used by a responsible or global maintainer when the patch touches multiple >> + areas of GDB, and the maintainer in question is only approving some of >> + those areas. When using this tag, add the area(s) at the end of the text. >> + This tag is also often described as "partial approval" >> + Usage: "Acked-By: Your Name (area)" > What are the possible "area"s? And how to indicate more than a single > area? "area of GDB" is used throughout the maintainers file without being specified anywhere, such as when explaining "Authorized Comitters":   - The Authorized Committers.     These are developers who are trusted to make changes within a specific     area of GDB without additional oversight. And all throughout the "Responsible maintainers" section. So I think it is understood well enough, especially since it is expected that the reviewers are the ones who should know if the patch touches multiple areas and so on. As for how to indicate more than one area in the tag itself, I thought of a comma separated list. I'll update the example to say the following:     Usage: "Acked-By: Your Name (area1[, area2, ...])" > > And a more general question: when the review comments are minor, we > are used to say something like "okay with those nits fixed", meaning > that there's no need for posting another version of the patch before > committing it "with those nits fixed". Is this an > Acked-By/Approved-By or Reviewed-By? The tags are just ways to make your intent obvious. If you were approving the patch "with the nits fixed", you use Approved-By, if you were approving only parts of the patch, use Acked-by, and if you think the patch is ok but can't/won't approve, use Reviewed-By. -- Cheers, Guinevere Larsen She/Her/Hers > > Thanks. >