From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 37A4F3858C39 for ; Tue, 7 Mar 2023 17:21:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37A4F3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 978B71E110; Tue, 7 Mar 2023 12:21:29 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1678209689; bh=0RitfzGI2EZ6M9bCl1ytvkrGjcSHhBjpFLIPj7nTgTo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hmjqR901aDUjwxoCykBopEskeuPOWLRZya97HoIg5Z9lp8K615o+hC99GXdDU7poS d46xHxDd51zAuI/Ud9DtmjgnmUpm+V9UCiOJ2HsuX2ZO2rckQacfkj4uLb4Mm74JX0 ZkC1Bkfli+c6PYZHxCz2QXsim2JOilDs6JsBgrmI= Message-ID: <2fd34bd5-fe16-e2d4-7585-f693fdc5d8dd@simark.ca> Date: Tue, 7 Mar 2023 12:21:28 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] Ensure index cache entry written in test Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20230306164553.1449009-1-tromey@adacore.com> <87sfegsj5f.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87sfegsj5f.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/7/23 09:58, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > >>> + gdb_test_no_output "maintenance wait-for-index-cache" > > Simon> I would perhaps put this command in the run_test_with_flags proc, so > Simon> that it applies to other tests as well. It shouldn't be necessary for > Simon> those tests, but if there's a bug somewhere, it would make it reproduce > Simon> more reliably. > > I made this change. It required the appended hunk as well, to avoid a > duplicate test name. > > I'm going to check it in now. Heh, we get that now: (gdb) maintenance selftest help Running selftest help_doc_invariants. help doc broken invariant: command 'maintenance wait-for-index-cache' help doc first line is not terminated with a '.' character Self test failed: self-test failed at /home/simark/src/binutils-gdb/gdb/unittests/command-def-selftests.c:99 Ran 1 unit tests, 1 failed I guess swap the lines? That's how other commands do it: Print value of expression EXP. Usage: print [[OPTION]... --] [/FMT] [EXP] Print backtrace of all stack frames, or innermost COUNT frames. Usage: backtrace [OPTION]... [QUALIFIER]... [COUNT | -COUNT] Simon