From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7653439A580B for ; Sat, 14 Aug 2021 04:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7653439A580B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17E45xiW003347 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 14 Aug 2021 00:06:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17E45xiW003347 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CA0501E813; Sat, 14 Aug 2021 00:05:58 -0400 (EDT) Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling To: Patrick Monnerat , gdb-patches@sourceware.org References: <20210813222411.3076-1-patrick@monnerat.net> From: Simon Marchi Message-ID: <3002b4db-52a4-b7a5-ca1a-49398ba439ed@polymtl.ca> Date: Sat, 14 Aug 2021 00:05:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210813222411.3076-1-patrick@monnerat.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 14 Aug 2021 04:05:59 +0000 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Aug 2021 04:06:26 -0000 On 2021-08-13 6:24 p.m., Patrick Monnerat via Gdb-patches wrote: > As observer is currently notified of breakpoint stop before handling its > auto-disabling after count is reached, the observer is never notified of > the disabling. > > The problem does not seem to affect gdb alone. However it impacts insight: > breakpoint GUI window is not properly updated upon auto-disable. > > This patch moves the observer notification after the auto-disabling > code. > > Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336 > > * gdb/breakpoint.c (bpstat_stop_status): move observer notification > after auto-disabling code. Note that GDB doesn't use ChangeLogs anymore. > --- > gdb/breakpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 89af44ee4c6..feca224ccf4 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -5491,7 +5491,6 @@ bpstat_stop_status (const address_space *aspace, > if (bs->stop) > { > ++(b->hit_count); > - gdb::observers::breakpoint_modified.notify (b); > > /* We will stop here. */ > if (b->disposition == disp_disable) > @@ -5501,6 +5500,7 @@ bpstat_stop_status (const address_space *aspace, > b->enable_state = bp_disabled; > removed_any = 1; > } > + gdb::observers::breakpoint_modified.notify (b); I looked at the change a bit more in depth, in particular at the various observers of breakpoint_modified. One of them is MI, who prints the =breakpoint-modified notification. That suggested that your change would affect that notification in a similar way that insight is affected. And indeed, if I run a program with a breakpoint with "enable count 1 1", the notification I get without your patch is: =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="n",... ^ And with the patch: =breakpoint-modified,bkpt={number="1",type="breakpoint",disp="dis",enabled="y", ^ I think the change is desirable in MI for the same reason it is desirable in insight. But this means we should add a test for it. Maybe gdb.mi/mi-breakpoint-changed.exp would be a good place for it. I don't think there's an official way to set a count on a breakpoint using MI. However, it seems to work through -break-enable, since -break-enable is implemented on top of the CLI "enable" command. So "-break-enable count 1 1" is equivalent to "enable count 1 1". It's not documented but... There is also the Python breakpoint_modified event. This script: def func(bp): print(bp.enabled) gdb.events.breakpoint_modified.connect(func) Prints "True" before your patch and "False" after. We should have a test for that too, ideally, I guess in gdb.python/py-breakpoint.exp. Simon