From: Simon Marchi <simon.marchi@polymtl.ca>
To: Joel Brobecker <brobecker@adacore.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, nilsgladitz@gmail.com
Subject: Re: [PATCH 3/4] gdb/dwarf: don't enqueue CU in maybe_queue_comp_unit if already expanded
Date: Tue, 23 Feb 2021 13:39:09 -0500 [thread overview]
Message-ID: <300663eb-c81b-65bb-f2a4-b650bda2d89e@polymtl.ca> (raw)
In-Reply-To: <20210223065302.GA370419@adacore.com>
On 2021-02-23 1:53 a.m., Joel Brobecker wrote:
> Hi Simon,
>
> On Wed, Jan 20, 2021 at 09:15:15PM -0500, Simon Marchi via Gdb-patches wrote:
>> Do you have an opinion on this?
>
> It's been two months since the patch has been waiting for feedback,
> with a ping a month ago. At this point, I think we should just trust
> your judgement on this one, and go ahead, especially if the person
> who reported the issue confirm his issue was fixed.
>
> WDYT?
Ok, I'll push them to master, and push them to gdb-10-branch after doing a bit of testing.
Simon
next prev parent reply other threads:[~2021-02-23 18:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 19:12 [PATCH 0/4] Fix CU expansion queue-related problems Simon Marchi
2020-11-17 19:12 ` [PATCH 1/4] gdb/dwarf: add some logging in dwarf2/read.c Simon Marchi
2020-12-09 21:08 ` Tom Tromey
2020-11-17 19:12 ` [PATCH 2/4] gdb/dwarf: add assertion in maybe_queue_comp_unit Simon Marchi
2020-12-09 21:12 ` Tom Tromey
2020-12-10 14:18 ` Simon Marchi
2021-01-21 2:18 ` Simon Marchi
2020-11-17 19:12 ` [PATCH 3/4] gdb/dwarf: don't enqueue CU in maybe_queue_comp_unit if already expanded Simon Marchi
2020-12-09 21:24 ` Tom Tromey
2020-12-10 14:52 ` Simon Marchi
2020-12-10 17:40 ` Simon Marchi
2021-01-21 2:15 ` Simon Marchi
2021-02-23 6:53 ` Joel Brobecker
2021-02-23 18:39 ` Simon Marchi [this message]
2021-02-23 23:32 ` Simon Marchi
2021-02-24 7:30 ` Joel Brobecker
2021-02-24 20:32 ` Tom Tromey
2020-11-17 19:12 ` [PATCH 4/4] gdb/dwarf: create and destroy dwarf2_per_bfd's CUs-to-expand queue Simon Marchi
2020-12-09 21:27 ` Tom Tromey
2020-11-23 22:17 ` [PATCH 0/4] Fix CU expansion queue-related problems Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=300663eb-c81b-65bb-f2a4-b650bda2d89e@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=nilsgladitz@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).