Re: [PATCH v2] gdb tests: Allow for "LWP" in thread IDs from info threads.

[John Baldwin <jhb@FreeBSD.org>]

On 4/17/23 1:22 PM, Tom Tromey wrote:
>>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
> 
>>> -	{.*[\r\n]+\* +([0-9]+) +Thread[^\r\n]* do_something \(n=\1\) at.*}
>>> +	{.*[\r\n]+\* +([0-9]+) +${tdlabel_re}[^\r\n]* do_something \(n=\1\) at.*}
>>> # Check for expected results when passing a valid thread handle
>>> to
>>> # thread_from_handle().
> 
> John> This one fails because the variable isn't expanded.  If I change the {}'s to
> John> quotes then the test fails.  If I inline the value of `tdlabel_re` here, the
> John> test passes.  I'm just not sure how to use a variable in a {} expression.
> 
> {} prevent substitutions.
> 
> One way to do this is to use "" but then you may need extra backslashes.
> 
> Another way is format:
> 
>    [format {... %s ... } $tdlabel_re]
> 
> Yet another way is subst:
> 
>    [subst -nobackslashes -nocommands {...the above...}]

Thanks for the pointers.  I went with the second approach in the V3 patch.

-- 
John Baldwin