From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2098.outbound.protection.outlook.com [40.107.115.98]) by sourceware.org (Postfix) with ESMTPS id 063CF3858D34 for ; Wed, 21 Feb 2024 18:31:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 063CF3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 063CF3858D34 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.98 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708540301; cv=pass; b=cQSGzUbghILflpEyIDO9izqJ5qg1lnSS7FLEJo//RG4itj/rKABYB3N7Z7CxmLCTEi6/ghezByYNJouhNAK//SAq0angT8xPJRtLidKBe8DjCtxquryclv8rTN8mek4oiSiW0OluOXdYEu9HlCTPLi8xmGZ25WsfzySmuWa2HbA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708540301; c=relaxed/simple; bh=CKyoV3SemoILL59COBGeRttsLOPzUgx/7I0L4pYHwas=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=jxtxyNvwQNiUk7og9KWkcKQ9L8BZCp1jM/Um7jav3dO96MaHgS7oisA6GK00LbK0JeeJ5W6rgNg/Eg89k1oIjVpkNFEb4idquTJYfx0UHL+tvzbXvYOlu5wFN7BMtqKLaevbax7ti1njG/Xvpxl1lwGYxH7nt2g75MGRhmXbFbY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fyFAsfSyaTlU7VUAieJV6IhPvRqZc6jjeGC5ArXMx5nTKR37YhY7Okp6dnGXjKGlOHO5Bq+N+N5s6HdtGEA4dIWl/MS93S5X68Gy9JnlkGYk4vm4gS9My9t+GPmZbxiQMw4RNg9+RGMmP/E7hY2wTeH44vorvjctfsDZwNTF83O8SirrvwKm/lCNLfEdZX+5jZzxPLYDnpjT4TzRz0+lZgaIuJojRCtol4Hqx8W02AX0usMz+5mclTQhdN/d1CHEN5iq/0YeS8PITVZxXbhvLo+0o+g82rPA8pVFlRcZbZXs7itLuNLVDQaM+XsekbbjmuIKNywWLtcOAwiXaY1omw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8udobyEYa85nT29EjwyFLZhL9QoKB5yRvyNcYpVoW0=; b=OiXZyLc3E6HrHd68cqiaKV+C0cmbY4xMImTVL4gt5UjsGwuRa12y4bPRAIkg4Tv3dDAmjT8nQ3dIWhXEJV+lJKicdg9jXu0ib3ne1RRZV1ZOi2UtjUOxTTW8QmAIcWnIt1o4EDlsq0nj8l04ntBPrBFuXGwlZUg0FWsZ+Ml/blnUQgeU3j2Ryep3BzuFnYS7NkJMa1S+BAAu44Nm5QtO5ER/MvloTG8EOJ50Pq4kkak2eQJ4zTbGkjQPF5FpZ2KUtOrzy0IYoAnWYiLidv72n0+OMLlb0riujet8cL/uJIaRU5aXfLUPNJCvhtcWQFquQjKNhFWFxHHPbjR+Bw7WtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8udobyEYa85nT29EjwyFLZhL9QoKB5yRvyNcYpVoW0=; b=QR1/6JjV7HCtF8NBGfMdyVLX9VPF07NGoDcyN+SicJw446wAlfLbS1Iqz05KETxdp1v8spe74Vbl2D3IIWq9xfRiQQqfR3n//IamWMflUS9g2rV79CePC3QGy32KUhkfX9/fWU3avKjvPV6aC3T0Pf3rxHhTir62ZCexBSRcO5mXCD3uGP18RjBqlarTkYTKGXu9TxqCfKMczCjuKZjdnCkiy5V+I/xfqNwu1y1F8LtfB2hFE6Li5iXslfHFfFfc47gYtrhVGyreNzUFJFlP1ze7riPzY5Y9+dPil0JZXRDThh4Fkl9WcLtG4jHSEL+FhvEijgX+sDqLT9+iMRfYjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YQXPR01MB5598.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:40::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.22; Wed, 21 Feb 2024 18:31:37 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::c742:8ac6:fbc:c437]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::c742:8ac6:fbc:c437%7]) with mapi id 15.20.7339.007; Wed, 21 Feb 2024 18:31:37 +0000 Message-ID: <30700bd1-5fde-45a1-bf84-5b238f71eb48@efficios.com> Date: Wed, 21 Feb 2024 13:31:36 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] gdb: remove some GCC version checks Content-Language: en-US To: Pedro Alves , Simon Marchi , Kevin Buettner Cc: gdb-patches@sourceware.org References: <20240221164709.54212-1-simon.marchi@efficios.com> <20240221100928.62ad46c4@f39-zbm-amd> <499636ca-75b0-4a4b-a685-4c84f4523665@simark.ca> <99297723-e4b9-4b94-803f-4998bcdf794a@palves.net> From: Simon Marchi In-Reply-To: <99297723-e4b9-4b94-803f-4998bcdf794a@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0184.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:f::27) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YQXPR01MB5598:EE_ X-MS-Office365-Filtering-Correlation-Id: 29c8cb76-0aad-4a4a-b0fe-08dc330b56dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LGTK+Wpcvbt+iwwNcAj+eqBDejV9ObghQEG7l9aaxt6TIlxk/QUTq5bSdxURJoY5IWHlkJvFmHUsbUxxl8x4MLhSv0BcHWuUhiTBhDcazBOGzCcnu3UCpYScmhmnCbGEO9vZeGGlR4mg+flBZqFE9uREOgmpKiAuHIguVUIrfMuRcO6w9mnvv//S0jSmoi4mgYzFe5qzhUvl4uT+LqoLDsKbojBNpDLR91k6QL0WnIawNXEX+Hd9R5IuZKZJ9+S+WavJmhkKwXUGLmMxOTbdjSPWpuOlwS8k23EbjGIl2Nnu8EsvaAJAXGRpcaXgVaw5J+Zvl+Tkgo3/H3u19xsA6o0Bzz7d5f7Zdx/2wxpIA6MqQGbrKLmsSD9XvjcD83CZUxzFOt0gYA1mlDnS0Xn9iqUosziFWql8oNQJ5UJHOl7PfICqfg4QTzGJkbtnr6AKX8sEgm6hSCsA1eiH81R6TppoxqqJfY6fhU22fw7pHfdtMNe/VwIL7LwTSzdt4n6YUPGxXdu0f/54Hd0UVGDqOqFWZC/thCz3gmC31wlKpKs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mm93OTh4Tzdmc0tGYUZwL3hqaUFTV0hDK2ZBVWV1WDVneEN5aGlEcW10WXEw?= =?utf-8?B?dzIwVjhmTEV1dTBGM09EMjVJY3pRYkxTNS9ubFVZL2lXamx2NE90cExMMGhy?= =?utf-8?B?YW1aSHpMZ01pb1lzRDRxVE5HSkxXRlovck5VdElIcTczZnROUG5xQjJhWElC?= =?utf-8?B?QkJNS1BHWlphdXBmZXRXNEZBQWVleGhuR3l0ajJab0tXOXZOY01QQ2lrd0tL?= =?utf-8?B?RDQ2TFVjcUpiRkpvUGNWQ0NxcVVrMlBlRjVIN1hGNEt6YVpsbXBReUpGY3M5?= =?utf-8?B?L3ltQ1RWdENKNm1WSVAzQWZneWwxNHNIWVFaU1lQOEtvZEQ2d3lTL0hCUzdI?= =?utf-8?B?dHJjSGxFdEJtVjdWaVRnb3FGaUhIZWFURnJjZHdBZ0ljLzZ6OVkrZWxHQnJy?= =?utf-8?B?YzF2NllGbmNoSUZyc29PcnBrTXBlbXpmekJNWTBKQU82aXVuVjJVdlM5M0hw?= =?utf-8?B?U3c1SERaOExMbmxpdGJKWDRrWVNnKzQwbUFnbm5jTFJoNGM2emtwTWtpLzV5?= =?utf-8?B?bU1tNW16akc0MGZMb1NMWE9OZUFnWVJ0MU1peWdndkVGWGhMbHcvbE41VVhs?= =?utf-8?B?K2daTGVyVG41Nm1FY3BGZFJmaHIrNFcwSy9lSWgxTFR6TGc0NWR6dUx0c0ZU?= =?utf-8?B?eWQrSU5xcitldytwcFcxWG4xeTBROHJiN0IxU1pGQ2JTdDFxdFZKcXVuWVpB?= =?utf-8?B?MU1iSzlJUS92ZzVzWldRMEcwbnVVNE5XT1hQMnVsaGdvRXErSWx2WHU4TnJO?= =?utf-8?B?Y1J3dHYveW1pN1R1Z1pXWDJxSmR6ak1zc0d3TUxONno5aGFOVitVTUtqWi9C?= =?utf-8?B?amZ4YVBBa1FEMzd1anoreHlMKytJTkxVK3RXMGxuYUpWOWozMU5hb3plcXdl?= =?utf-8?B?d3VCZXlYcU1BWmxWY0UyemxCajlOazhOWjkwSHVBeVJVTTduRFhONExVMTJn?= =?utf-8?B?dFlMUzcrOVo2OHRFeWdnS0hlU3Mrc251ZW12TThWNWgvcGF5eU1FT3JSZkNE?= =?utf-8?B?eFVYMTQzZ2JTR01raHNuNnhsa0toRmxiK0l4V0ZMbnRSVFRqUWpDTDUvQk1X?= =?utf-8?B?eTAyWmdoTHl5VnVHY1RmajQ1SzhEWlBGcmhqM0c2NVBMNXUvbE1yS1lTdnJN?= =?utf-8?B?WHVvQ21BMU9GSEIzTmwvdklNN1NQeTh0K2YvU0FoUFdKK2VzV0NHejhtdkhX?= =?utf-8?B?MGZ5bm1QTWFnQVlaMmNCM3FaMzBWODA4bm04ZXhkYU50WkQzLzNWUlJMb09S?= =?utf-8?B?dDcrUXVLQVk4RGhIN2d3dWMrTkZmS0g5WG41WWxTdzJOcFRXZkk1UDRYak9G?= =?utf-8?B?bXZTbzVJbjg1QTBuYzNsRlR3ckJ6QWo2MU5RR1o1WVljckkxaWROeUlhcHpX?= =?utf-8?B?dWdqUWVBZnRmQWtYaFAxNkNKaFB6VDQyOGpXSVZEVVZqbFFNVzhYbWFFZkxk?= =?utf-8?B?aUlnbHRGaVBFUFd1NkZnLzIvNzR6QTZ4RHV5R05BQTFIN2JVamlPWFlkUEtK?= =?utf-8?B?M1JHRGhZeWYrNFRlZTN3ODFmaGt6am1SeWU5dmxLMHR2OXhDY1ZreXVoV0l6?= =?utf-8?B?SVcvKzQ0M1RYVEhGWTRYZXczNTlzNEk1elJuYWxmUXdlK0dYN1VFT1RMSm9N?= =?utf-8?B?eDhzd1pyV29aeGpaczkvN2U5ZE9rQWdOM2Vqd3lpYmxXTGVnVDBCMHQ5U0I1?= =?utf-8?B?Vi93bVlGWGZxMEc4UEFXakZLeXBLOVZhYzdRV2V1SnZSVjBZOUNrMjJXWkI0?= =?utf-8?B?d0hPMGNkaS9SVHpnTTNHaUhaYTVGMXpGcnNnYjVwb1RYSTdDdEVTQlluVDVa?= =?utf-8?B?VDI3L2hVN1ZQSjVoUVdpdjVadmtxUWJhb3VnbjluM0NOV0RQTktPUG41YU5D?= =?utf-8?B?SE41Q2J2QTNKTHBGaW1Hd1Y5SzZQdmp6bU5NZDAycm1yNjBBVU5qM2IvakhR?= =?utf-8?B?QklQM1NqNm1rM0VwS1BpeDZ6TCt4U2lnQnFTUzUzSjVucW8zdmZhdmlta25W?= =?utf-8?B?RDgyWEJtSHhOOG10aU5JUUFNQ1d2VFpkU1ArMkdGc2Y2L1BvN1RuZS9GTmI0?= =?utf-8?B?L29RbTlaTEVVcGFTTlhiaG9DU1Jla1RDK0hZMTlocU1lUlZrUjNPZEcwRE9R?= =?utf-8?Q?jLGNExQ1VIQkvV/Aot23pCtWo?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29c8cb76-0aad-4a4a-b0fe-08dc330b56dc X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 18:31:37.6025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rLAoKQOz/UFKSEZPMmtPMlQMVmLrdvYGFi5aKjZ63xDW7V8A0x6MVUq1grLia2gXnx2ji3B2ZLehTFVWt2j03Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB5598 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-02-21 12:46, Pedro Alves wrote: > On 2024-02-21 17:36, Simon Marchi wrote: >> On 2/21/24 12:09, Kevin Buettner wrote: >>> On Wed, 21 Feb 2024 11:46:51 -0500 >>> Simon Marchi wrote: >>> >>>> New in v2: >>>> >>>> - remove changes to nat/x86-gcc-cpuid.h >>>> - adjust indentation in tracepoint.h >>>> >>>> Since we now require C++17, and therefore gcc >= 9, it's no longer >>>> useful to have gcc version checks for older gcc version. >>> >>> Both patches LGTM. >>> >>> Reviewed-by: Kevin Buettner >>> >> >> Thanks. I'll wait for a confirmation from Pedro as well, since he gave >> comment on v1. >> > > LGTM. > > Approved-By: Pedro Alves > Thanks, pushed. Simon