From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: gdb-patches@sourceware.org
Subject: [PATCH] gdb: Remove unused extra_lines variable
Date: Sun, 25 Sep 2022 08:17:42 +0000 [thread overview]
Message-ID: <3090ae2157c8eae596b1bf5989c1853b865fdacf.1664093762.git.research_trasio@irq.a4lg.com> (raw)
Clang generates a warning if there is a variable that is set but not used
otherwise ("-Wunused-but-set-variable"). On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).
The only extra_lines use in arrange_linetable function is removed on the
commit 558802e4d1c5dcbd0df7d2c6ef62a6deac247a2f
("gdb: change subfile::line_vector to an std::vector"). So, this variable
should be removed to prevent a build failure.
gdb/ChangeLog:
* xcoffread.c (arrange_linetable): Remove unused extra_lines.
---
gdb/xcoffread.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index b7d65771115..aa88cbc724d 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -419,8 +419,6 @@ add_stab_to_list (char *stabname, struct pending_stabs **stabvector)
static void
arrange_linetable (std::vector<linetable_entry> &old_linetable)
{
- int extra_lines = 0;
-
std::vector<linetable_entry> fentries;
for (int ii = 0; ii < old_linetable.size (); ++ii)
@@ -436,12 +434,6 @@ arrange_linetable (std::vector<linetable_entry> &old_linetable)
e.line = ii;
e.is_stmt = 1;
e.pc = old_linetable[ii].pc;
-
- /* If the function was compiled with XLC, we may have to add an
- extra line entry later. Reserve space for that. */
- if (ii + 1 < old_linetable.size ()
- && old_linetable[ii].pc != old_linetable[ii + 1].pc)
- extra_lines++;
}
}
base-commit: 58d69206b8173b9d027a6c65f56cdaf045ae6e64
--
2.34.1
next reply other threads:[~2022-09-25 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 8:17 Tsukasa OI [this message]
2022-09-26 9:00 ` Bruno Larsen
2022-09-30 15:50 ` Tsukasa OI
2022-09-29 17:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3090ae2157c8eae596b1bf5989c1853b865fdacf.1664093762.git.research_trasio@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).