From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30099 invoked by alias); 17 Oct 2017 15:54:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30089 invoked by uid 89); 17 Oct 2017 15:54:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=captured X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Oct 2017 15:54:03 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26D197EA99; Tue, 17 Oct 2017 15:54:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 26D197EA99 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FEF461780; Tue, 17 Oct 2017 15:54:01 +0000 (UTC) Subject: Re: Sporadic failures of selftest tests To: Ulrich Weigand References: <20171017154758.DD85FD807C2@oc3748833570.ibm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <30d4dc25-a59b-1196-3bc3-c8b982191ec0@redhat.com> Date: Tue, 17 Oct 2017 15:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171017154758.DD85FD807C2@oc3748833570.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00531.txt.bz2 On 10/17/2017 04:47 PM, Ulrich Weigand wrote: > But what confuses me is that in a normal build, GDB by default gets > built with -O2 for me, so I'm wondering why you had to use special > CXXFLAGS above. Ah, sorry for not being clearer. The build tree that I'm using is configure with explicit CXXFLAGS="-g3 -O0", and so I had to use CXXFLAGS to override what I had configured with. > Also, I'm wondering why I'm only seeing this now, > when this has apparently been broken all the time. Just some random > timing issues that are now different for some reason? Commit bf4692711232 ("Eliminate catch_errors") also did this: @@ -1145,7 +1142,15 @@ captured_main (void *data) change - SET_TOP_LEVEL() - has been eliminated. */ while (1) { - catch_errors (captured_command_loop, 0, "", RETURN_MASK_ALL); + TRY + { + captured_command_loop (); + } + CATCH (ex, RETURN_MASK_ALL) + { + exception_print (gdb_stderr, ex); + } + END_CATCH } So most probably before that commit captured_command_loop wasn't inlined in captured main (unless LTO, maybe). Thanks, Pedro Alves