From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [pushed] [gdb/testsuite] Clean up before compilation in gdb.ada/call-no-debug.exp
Date: Sat, 17 Jun 2023 12:50:02 +0200 [thread overview]
Message-ID: <30dc92ca-6fd5-46f1-d716-463be55cba98@suse.de> (raw)
In-Reply-To: <877cs345ij.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On 6/16/23 20:38, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tom> Running test-case gdb.ada/call-no-debug.exp with target board unix/-m64 works
> Tom> fine, but if we run it again with target board unix-m32, we run into:
>
> Thanks for doing this.
>
> If gdb's test suite could detect when a new .exp is started, we could
> make this always work by removing the corresponding standard output directory.
Hi,
thanks for the suggestion, I've implemented it in gdb_init. WDYT?
Thanks,
- Tom
[-- Attachment #2: 0001-gdb-testsuite-Clean-standard_output_file-dir-in-gdb_.patch --]
[-- Type: text/x-patch, Size: 2117 bytes --]
From f6b5a812244b824a72f305e74f2853d03d4d3ed1 Mon Sep 17 00:00:00 2001
From: Tom de Vries <tdevries@suse.de>
Date: Sat, 17 Jun 2023 12:37:46 +0200
Subject: [PATCH] [gdb/testsuite] Clean standard_output_file dir in gdb_init
In commit e2adba909e7 ("[gdb/testsuite] Clean up before compilation in
gdb.ada/call-no-debug.exp") I added some code in the test-case to remove some
files at the start of the test-case:
...
remote_file host delete [standard_output_file prog.o]
remote_file host delete [standard_output_file prog.ali]
...
Replace this with cleaning up the entire directory instead, for all
test-cases.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.ada/call-no-debug.exp | 5 -----
gdb/testsuite/lib/gdb.exp | 3 +++
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/gdb/testsuite/gdb.ada/call-no-debug.exp b/gdb/testsuite/gdb.ada/call-no-debug.exp
index df81c87ade2..422b83761d9 100644
--- a/gdb/testsuite/gdb.ada/call-no-debug.exp
+++ b/gdb/testsuite/gdb.ada/call-no-debug.exp
@@ -21,11 +21,6 @@ require allow_ada_tests
standard_ada_testfile prog
-# Since we use no-force to compile prog, make sure we don't pick up files
-# from a previous compilation.
-remote_file host delete [standard_output_file prog.o]
-remote_file host delete [standard_output_file prog.ali]
-
# Compile pck without debuginfo but prog with it.
if {[gdb_compile_ada $srcdir/$subdir/$testdir/pck.adb \
[standard_output_file pck.o] object {}] != ""} {
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index f214a6bb54d..741b851b900 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -6420,6 +6420,9 @@ proc default_gdb_init { test_file_name } {
set gdb_test_file_name [file rootname [file tail $test_file_name]]
+ # Clean directory containing the standard output files.
+ remote_exec build "rm -rf [standard_output_file ""]"
+
# Make sure that the wrapper is rebuilt
# with the appropriate multilib option.
if { $gdb_wrapper_target != [current_target_name] } {
base-commit: 34a6dcd4422a194a45ae5297ca6d0d56d4c75e97
--
2.35.3
next prev parent reply other threads:[~2023-06-17 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 11:33 Tom de Vries
2023-06-16 18:38 ` Tom Tromey
2023-06-17 10:50 ` Tom de Vries [this message]
2023-06-17 20:14 ` Tom Tromey
2023-06-19 14:25 ` Luis Machado
2023-06-19 14:26 ` Luis Machado
2023-06-19 17:12 ` Tom de Vries
2023-06-19 17:22 ` Tom Tromey
2023-06-21 5:31 ` Tom de Vries
2023-06-21 7:40 ` Luis Machado
2023-06-22 16:01 ` Tom Tromey
2023-06-19 17:19 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30dc92ca-6fd5-46f1-d716-463be55cba98@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).