Re: [PATCHv6 3/3] gdb/python: add gdb.RemoteTargetConnection.send_packet

[Simon Marchi <simark@simark.ca>]

On 2021-11-16 7:48 a.m., Andrew Burgess via Gdb-patches wrote:
> Simon, Eli,
>
> Thanks for the feedback, I think I've addressed everything in this
> update.
>
> Simon, sorry for not quite getting your point the first time through.
> I believe that this revision should address your concerns.  I have not
> been as restrictive as you suggested, but hopefully this should still
> be acceptable.
>
> So, you can still pass a string, but the documentation is specific
> that it must be possible to convert the string to a bytes object using
> the ascii codec.  This allows for what I assume would be the most
> common use case:
>
>   conn.send_packet("some_ascii_text")
>
> But if we revisit your example, we now get:
>
>   res = conn.send_packet('X555555558028,4:\xff\x03\x02\xff')
>   UnicodeEncodeError: 'ascii' codec can't encode character '\xff' in position 10: ordinal not in range(128)
>
> In which case, the solution is, as your suggest, to pass a bytes
> object:
>
>   res = conn.send_packet(b'X555555558028,4:\xff\x03\x02\xff')
>   print(res)
>   b'OK'
>
> I've tested this code with Python 3.7 and Python 2.7 and it seems to
> work fine.  I've extended the test to include your example and related
> cases, hopefully that should cover what I've said above.
>
> Let me know what you think,

If I had done it myself, I would have accepted just "bytes" objects, to
be more straightforward in the implementation and the doc.  But I am
still happy with what you have, the user won't have sneaky encoding
bugs.  So, +1 from me.

Simon