Re: [PATCH 1/4] gdb: add new function quick_symbol_functions::has_unexpanded_symbols

[Simon Marchi <simon.marchi@polymtl.ca>]

> diff --git a/gdb/quick-symbol.h b/gdb/quick-symbol.h
> index f06ceff41c2..096053e75e9 100644
> --- a/gdb/quick-symbol.h
> +++ b/gdb/quick-symbol.h
> @@ -86,6 +86,12 @@ struct quick_symbol_functions
>       available.  */
>    virtual bool has_symbols (struct objfile *objfile) = 0;
>  
> +  /* Return true if OBJFILE has any unexpanded symbols.  A return value of
> +     false indicates there are no unexpanded symbols, this might mean that
> +     all of the symbols have been expanded (full debug has been read in),
> +     or it might been that OBJFILE has no debug information.  */
> +  virtual bool has_unexpanded_symbols (struct objfile *objfile) = 0;

Naming nit: I would maybe suggest to name this "has_unexpanded_symtabs",
since the unit of expansion is a symtab, not a symbol.  I would
understand it better this way.

> diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c
> index b839194e2f7..cfc3bed9222 100644
> --- a/gdb/symfile-debug.c
> +++ b/gdb/symfile-debug.c
> @@ -100,6 +100,19 @@ objfile::has_partial_symbols ()
>    return retval;
>  }
>  
> +/* See objfiles.h.  */
> +bool
> +objfile::has_unexpanded_symbols ()
> +{
> +  for (const auto &iter : qf)
> +    {
> +      if (iter->has_unexpanded_symbols (this))
> +	return true;
> +    }
> +
> +  return false;
> +}

I find it odd that this is implemented in this file.  I thought that
symfile-debug.c was just for wrappers that add debug logging.  Maybe
that's how it was back then and it just evolved from there, when
objfiles gained the capability to have multiple symbol providers.

So I think it's fine to add this here, because it's in line with what's
already there, but I would suggest adding the debug logs like there is
in the other functions.

Otherwise, LGTM.

Simon