From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23184 invoked by alias); 6 Feb 2019 19:56:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23176 invoked by uid 89); 6 Feb 2019 19:56:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=70, 62, 6.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Feb 2019 19:56:40 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40E3245F86; Wed, 6 Feb 2019 19:56:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 55A665C1B2; Wed, 6 Feb 2019 19:56:36 +0000 (UTC) Subject: Re: [PATCH] Readline: Cleanup some warnings To: Philippe Waroquiers , Tom Tromey , Joel Brobecker References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> <20190201080533.GA31043@adacore.com> <877eejvfoq.fsf@tromey.com> <1549047248.2630.7.camel@skynet.be> Cc: Alan Hayward , "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <310315f8-62ab-2eff-042f-9f2ae9de07da@redhat.com> Date: Wed, 06 Feb 2019 19:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1549047248.2630.7.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00044.txt.bz2 On 02/01/2019 06:54 PM, Philippe Waroquiers wrote: > > Switching to this readline version causes the following checks to fail: > FAIL: gdb.gdb/selftest.exp: send SIGINT signal to child process (timeout) > FAIL: gdb.gdb/selftest.exp: thread 1 (timeout) > FAIL: gdb.gdb/selftest.exp: backtrace through signal handler (timeout) > > Apart of that, no problem seen." See the description in commit 4a11f2065906, which was later reverted: ~~~ Sync readline/ to version 7.0 alpha ... After the sync there is one testsuite regression, the test "signal SIGINT" in gdb.gdb/selftest.exp which now FAILs. Previously, the readline 6.2 SIGINT handler would temporarily reinstall the underlying application's SIGINT handler and immediately re-raise SIGINT so that the orginal handler gets invoked. But now (since readline 6.3) its SIGINT handler does not re-raise SIGINT or directly invoke the original handler; it now sets a flag marking that SIGINT was raised, and waits until readline explicitly has control to call the application's SIGINT handler. Anyway, because SIGINT is no longer re-raised from within readline's SIGINT handler, doing "signal SIGINT" with a stopped inferior gdb process will no longer resume and then immediately stop the process (since there is no 2nd SIGINT to immediately catch). Instead, the inferior gdb process will now just print "Quit" and continue to run. So with this commit, this particular test case is adjusted to reflect this change in behavior (we now have to send a 2nd SIGINT manually to stop it). ~~~ Thanks, Pedro Alves