Re: [PATCH 0/4] libthread_db initialization changes related to upcoming glibc-2.34

Re: [PATCH 0/4] libthread_db initialization changes related to upcoming glibc-2.34

[Carlos O'Donell]

> This patch series contains changes necessary for GDB to be able to
> debug threaded programs using glibc-2.34.
> 
> The actual change to GDB sources are contained in the first patch; the
> remainder deal with several testing issues that I ran into.

I have tested this in Fedora Rawhide with a new glibc, and a new gdb
and it looks good to me. There were some additional failures which I
do not think are related to the glibc issues, but are related to the
new appearance of threads even when the program doesn't explicitly
call pthread_create (because now we always load libthread_db).

For example gdb/testsuite/gdb.threads/linux-dp.exp needs some additional
cleanup on rawhide, but it's not bad, some of the gdb_test_multiple do
not expect thread lists.

I think this patch series goes in the right direction. It improves the
debugging under the new glibc where libc.so.6 contains all of the
threading functionality. As we deploy the new glibc the testsuite will
need a little more attention.

Please consider merging this series since it unblocks upstream glibc
testing with upstream gdb. Go GNU Toolchain :-)

> Kevin Buettner (4):
>   libthread_db initialization changes related to upcoming glibc-2.34
>   testsuite/glib-2.34: Match/consume optional libthread_db related
>     output
>   print-symbol-loading.exp: Allow libc symbols to be already loaded
>   mi-sym-info.exp: Increase timeout for 114-symbol-info-functions
> 
>  gdb/linux-thread-db.c                         | 24 +++++++-
>  gdb/solib.c                                   | 10 +++-
>  .../gdb.base/execl-update-breakpoints.exp     |  1 +
>  .../gdb.base/fork-print-inferior-events.exp   |  3 +-
>  .../gdb.base/print-symbol-loading.exp         | 15 ++++-
>  gdb/testsuite/gdb.mi/mi-sym-info.exp          | 56 ++++++++++---------
>  6 files changed, 73 insertions(+), 36 deletions(-)
> 
> -- 
> 2.31.1


-- 
Cheers,
Carlos.

Re: [PATCH 0/4] libthread_db initialization changes related to upcoming glibc-2.34

[Carlos O'Donell]

On 6/11/21 12:35 PM, Carlos O'Donell wrote:
>> This patch series contains changes necessary for GDB to be able to
>> debug threaded programs using glibc-2.34.
>>
>> The actual change to GDB sources are contained in the first patch; the
>> remainder deal with several testing issues that I ran into.
> 
> I have tested this in Fedora Rawhide with a new glibc, and a new gdb
> and it looks good to me. There were some additional failures which I
> do not think are related to the glibc issues, but are related to the
> new appearance of threads even when the program doesn't explicitly
> call pthread_create (because now we always load libthread_db).
> 
> For example gdb/testsuite/gdb.threads/linux-dp.exp needs some additional
> cleanup on rawhide, but it's not bad, some of the gdb_test_multiple do
> not expect thread lists.
> 
> I think this patch series goes in the right direction. It improves the
> debugging under the new glibc where libc.so.6 contains all of the
> threading functionality. As we deploy the new glibc the testsuite will
> need a little more attention.
> 
> Please consider merging this series since it unblocks upstream glibc
> testing with upstream gdb. Go GNU Toolchain :-)

Simon,

What do you think of these changes? I would really like to unblock the
upstream glibc and upstream gdb and ensure that we have a solution
in upstream gdb that works with upstream glibc.

I want to be able to recommend top-of-tree for both glibc and gdb for
testing the latest changes.

-- 
Cheers,
Carlos.

Re: [PATCH 0/4] libthread_db initialization changes related to upcoming glibc-2.34

[Carlos O'Donell]

On 6/11/21 6:21 PM, Kevin Buettner wrote:
> After making changes requested by Simon, I've pushed this
> series.
> 
> Thanks to both Carlos and Simon for the quick reviews.

Thank you Kevin and Simon for prioritizing the debug experience
of GNU Toolchain developers :-)

-- 
Cheers,
Carlos.

Re: [PATCH 0/4] libthread_db initialization changes related to upcoming glibc-2.34

[Kevin Buettner]

After making changes requested by Simon, I've pushed this
series.

Thanks to both Carlos and Simon for the quick reviews.

Kevin

On Thu, 10 Jun 2021 10:26:37 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> This patch series contains changes necessary for GDB to be able to
> debug threaded programs using glibc-2.34.
> 
> The actual change to GDB sources are contained in the first patch; the
> remainder deal with several testing issues that I ran into.
> 
> Kevin Buettner (4):
>   libthread_db initialization changes related to upcoming glibc-2.34
>   testsuite/glib-2.34: Match/consume optional libthread_db related
>     output
>   print-symbol-loading.exp: Allow libc symbols to be already loaded
>   mi-sym-info.exp: Increase timeout for 114-symbol-info-functions
> 
>  gdb/linux-thread-db.c                         | 24 +++++++-
>  gdb/solib.c                                   | 10 +++-
>  .../gdb.base/execl-update-breakpoints.exp     |  1 +
>  .../gdb.base/fork-print-inferior-events.exp   |  3 +-
>  .../gdb.base/print-symbol-loading.exp         | 15 ++++-
>  gdb/testsuite/gdb.mi/mi-sym-info.exp          | 56 ++++++++++---------
>  6 files changed, 73 insertions(+), 36 deletions(-)
> 
> -- 
> 2.31.1
> 

[PATCH 0/4] libthread_db initialization changes related to upcoming glibc-2.34

[Kevin Buettner]

This patch series contains changes necessary for GDB to be able to
debug threaded programs using glibc-2.34.

The actual change to GDB sources are contained in the first patch; the
remainder deal with several testing issues that I ran into.

Kevin Buettner (4):
  libthread_db initialization changes related to upcoming glibc-2.34
  testsuite/glib-2.34: Match/consume optional libthread_db related
    output
  print-symbol-loading.exp: Allow libc symbols to be already loaded
  mi-sym-info.exp: Increase timeout for 114-symbol-info-functions

 gdb/linux-thread-db.c                         | 24 +++++++-
 gdb/solib.c                                   | 10 +++-
 .../gdb.base/execl-update-breakpoints.exp     |  1 +
 .../gdb.base/fork-print-inferior-events.exp   |  3 +-
 .../gdb.base/print-symbol-loading.exp         | 15 ++++-
 gdb/testsuite/gdb.mi/mi-sym-info.exp          | 56 ++++++++++---------
 6 files changed, 73 insertions(+), 36 deletions(-)

-- 
2.31.1