From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D08003858D39 for ; Tue, 19 Sep 2023 19:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D08003858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38JJCHhK017828 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 15:12:22 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38JJCHhK017828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1695150742; bh=3tC44Au7m6lUCrO+/GZuYctUJowbUjOMYKAaiC9QliA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mkoRrbsnMgQKKa+Eeu1ZOuu9AOhmdLQ815ZwrENz/s3ky8HlBYoVEgCWHVUzCZf20 OsVRIiuwazw5Gpn2/Vs7SByw0bf96Bthat3a6sRH75zBwpt2MWGDSxZbHzYzfJRlZx ZkF24c20pvSvnZS8QyeutKXdfbvmME4A9QHgLcnY= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E5D821E028; Tue, 19 Sep 2023 15:12:16 -0400 (EDT) Message-ID: <313fd82d-4827-4493-b278-be5172f799d4@polymtl.ca> Date: Tue, 19 Sep 2023 15:12:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 17/18] [gdb/testsuite] sme: Add SVE/SME testcases Content-Language: fr To: Luis Machado , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20230918212651.660141-1-luis.machado@arm.com> <20230918212651.660141-18-luis.machado@arm.com> From: Simon Marchi In-Reply-To: <20230918212651.660141-18-luis.machado@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 19 Sep 2023 19:12:17 +0000 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/18/23 17:26, Luis Machado wrote: > v7: > > - Bail out from sme tests if we have a remote target, due to lack of > support in the RSP. > > v3: > > - Additional documentation for some testcases based on upstream reviews. > - Addressed upstream review comments. > > v2: > - Introduced a couple helper functions to determine the available SVE and SME > vector lengths. > > - Before running a batch of tests, validate that the target supports a certain > SVE vector length or SME streaming vector length. If not supported, skip > that batch of tests. > > - Fixed up native core file testing to remove generation of a spurious core > file, which later would be reported as unexpected by the testsuite. > > - Fixed tpidr2 dump in core file tests. > -- > > Add 5 SVE/SME tests to exercise all the new features like reading/writing > registers, pseudo-registers, signal frames and core files. > > - Sanity check for SME: Gives a brief smoke test to make sure the most basic > of features are working correctly. > > - ZA unavailability tests: Validates the behavior/content of the ZA register > is correct when no payload is available. It also exercises changing the > vector lengths. > > - ZA Availability tests: These tests exercise reading/writing to all the > possible ZA pseudo-registers, and validates the state is correct. > > - Core file tests: Validates that core file reading and writing works > correctly and that all state dumped/loaded is sane. This is exercised for > both Linux Kernel core files and gcore core files. > > - Signal frame tests: Validates the correct restoration of SME/SVE/FPSIMD > values across signal frames. > > Since some of these tests are very lengthy and take a little while to run > (under QEMU at the moment), I decided to parallelize them into smaller > chunks so we can throw some more CPU power at them so they run faster. > > I'd still like to add a few more tests to give the testsuite more coverage > in the areas of SME/SVE. Hopefully in the near future that will happen. > > Just a reminder that these SME tests are currently unsupported when gdb is > connected to a remote target. That's because the RSP doesn't support > communicating changes in vector lenghts mid-execution, so gdb will always > get wrong state from the remote target. > > Co-Authored-By: Ezra Sitorus > Reviewed-by: Thiago Jung Bauermann When applying the patch, git says: .git/rebase-apply/patch:796: indent with spaces. unsupported "aarch64 sve/sme tests not supported for remote targets" .git/rebase-apply/patch:1469: indent with spaces. unsupported "aarch64 sve/sme tests not supported for remote targets" .git/rebase-apply/patch:2133: indent with spaces. unsupported "aarch64 sve/sme tests not supported for remote targets" .git/rebase-apply/patch:2870: indent with spaces. unsupported "aarch64 sve/sme tests not supported for remote targets" .git/rebase-apply/patch:3539: new blank line at EOF. + warning: 5 lines add whitespace errors. Can you please fix them? Otherwise, I did a quick check on the newly added conditions to skip the tests on remote, they LGTM. So with the whitespaces issue fixed: Approved-By: Simon Marchi Simon