From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic312-25.consmr.mail.ir2.yahoo.com (sonic312-25.consmr.mail.ir2.yahoo.com [77.238.178.96]) by sourceware.org (Postfix) with ESMTPS id A4B6C3870845 for ; Mon, 15 Jun 2020 15:48:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A4B6C3870845 X-YMail-OSG: 2ITpZB0VM1k2Sx8T7f71gDIIUlyNqlFLr2r1TIXlpCYbUi05Z8BCCx4RCVpgDgR TyKb2SpdVt0o0RxfvayL4RGn8fKRbJpV_TXjdzAyVw42M_.XN9Gqe7GUNnK5GzOHIjHsbOVLT47R eM9nHRax33Cl__JMP_7qG934kVCMbHOtGRMbsSmDtv3F8c1WU_.CV1Lncxpx3aP6WrvS9Ohvz4BL 2MlFFEjaW1j4j2Ag15C38nS.RdpHCfVJcpOratdPGVf861Miwh1gEvQ4zvM_2sVkebocfdcV35cp CrvdYf580AznbfylZiZ_JpxqCViweKYk44QMrlL3QM5MXTcLkN8Sy3ZYfe5T1yyfLfg5rwu49.f. S6SPuTyx4cexg_CttJQqSdApXXgIvRO9kys6zH6jE4NHABYGASmjtMcdRXukiYfKod9Dd69tpyOf KI02hcwSIjE8oVS7rjmULfceWDLQfS.AWego8LcWMtELViUbM7sCEA9dwUBpC5nB5x5iEiX_LAMZ W54xYmXmQyGBwwtVo3nRbgAbQU44wcVIz1HpL_xJz0r9UEf6bnkNFtXWrGe7I8hN3PQ90FvFyj5r VAejK5Hc7jnw_mPxz.NjQX0hiNUjLyYcxdBBAy.0_IRsLp3MCBVz8tr6_RzfPZ9dcP6A5SzvbtMy ByWdAW0MiniWZmyYirIwE2VYMmc3NNpLtQIX4FmMj2N0H4TPeR.LVZi55wx3r4GJYSZN11BfZqcy pY6w1Rq0pZfexIGx4kky35Qe9wj8vOjipA4QlRMYbpWHUvtSDPD_bQadNkbgk.ECVsXt5OnBGq7X A6yxtutExvWLSMC.1HjMWdRk6p6szQpm7UwxVAI8Dx92qSSeUtMo7Brzc_0384CJQN8yFRRdnUgj ru0CjanvNV5zefHGmtuZMkEfd9D0ncw3JLQovZEsDxYMsaSCKa5nhMKXacImDUbw0OwXk_FysesP Pnm5AOMNInlcw7kCoMzY6fG0jHtEF6q6iFRYudUfqVVvBO4f41wroKBDP15UvxX8Hw0hHVUW4NHN ycWo4PZmkSWZwWctau0mryvmBwbUMIl7DRELJQ2_pfRbdMfddJeDYxHJre9m4C1I.okMAj6eGLfp 61akbFWNEJDs_3TC6VNTTrIMvEA7SHCZRls698FuZd7oCfQ3yS0JeHUiszltIwcCRlU5GdEcSNrr HVIX.NdS2dK0ARrwvCx8Tq2Wm.0Z0y97hYfnYaafEcwV4LPyIESo7Xt8SmcC9e79xnZRo2DH52EY 15GtG0v.OHVmZr4WvlsbY4UDhZtsFh7nj9JhvmgpcOd0diCVsL26Y.0Ijg61r9D6ZJwUEMsVb1rX .GekJiYHm6qH5_lmDVinF6jc67E1gUE4_MSfNTIMAlTM- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ir2.yahoo.com with HTTP; Mon, 15 Jun 2020 15:48:22 +0000 Date: Mon, 15 Jun 2020 15:48:19 +0000 (UTC) From: Hannes Domani To: Phi Debian , Pedro Alves Cc: gdb-patches@sourceware.org Message-ID: <314644177.1902979.1592236099059@mail.yahoo.com> In-Reply-To: <3011c306-2c6c-228f-07eb-95d3ff560942@redhat.com> References: <38b5d874-cdf2-50e7-dc76-aed3fee20334@redhat.com> <3011c306-2c6c-228f-07eb-95d3ff560942@redhat.com> Subject: Re: TUI enhancement suggestion. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.16119 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 15:48:25 -0000 Am Montag, 15. Juni 2020, 16:21:11 MESZ hat Pedro Alves via Gdb-patches Folgendes geschrieben: > On 6/11/20 2:55 PM, Phi Debian via Gdb-patches wrote: > > Ok I got the big picture, the little patch I made was more a demonstrat= or > > than a final patch, I don't know the review process. > > > > As soon as I can I redo one, with our remarks. > > > > Regarding the underline going up to printf I made it on purpose as I fi= nd > > it less intrusive, underlinie space is simple, while underlining text > > (source) can render less readable again (like colors), so it is somethi= ng I > > can spot quickly but not too intrusive. I use very tall xterm, spotting= the > > underline in the space part is very easy easier thanjust the little > > > before the line number.. That was the reasoning... Yet I admit, when th= ere > > is no styling it should works too so I will look again :) > > Note that people are working on adding support for range stepping to gdb: > > https://sourceware.org/pipermail/gdb-patches/2020-May/168673.html > > I can see that evolving such that the TUI would highlight the part of the > line that corresponds to the current statement, instead of the whole line= . > > Like: > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printf ("foo); ++i; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^^^^^^^^^^ > > And after a statement-step: > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printf ("foo); ++i; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^ > > So I think that it is better if both the reverse-video and the underline > highlight methods highlight the exact same characters. > > Then, we could have a separate setting to pick between highlighting > the whole line including the whitespace on the left, as we do > currently: > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printf ("foo); ++i; > ^^^^^^^^^^^^^^^^^^^^^^^^^ > > and highlighting the current line's text only, no highlight on the left > empty space.=C2=A0 This is similar to what e.g., Visual Studio highlights > (https://www.atlascode.com/wp-content/uploads/2017/04/stepintospecific-or= iginal.gif), > for example: > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printf ("foo); ++i; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^^^^^^^^^^^^^^^^ > > and highlighting just the left of the current line: > >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 printf ("foo); ++i; > ^^^^^^ > > like you are suggesting. > > But that would be orthogonal to reverse vs underline.=C2=A0 I.e., we woul= d > have a setting for "how do highlight" vs a setting for "what to highlight= ". > > > > I can't work too much on this unfortunately so it may be a while since = I > > come black to this. In my range stepping patchset I "highlight" the current column position in = the TUI as well, but since no end-column information is available, it's only 1 character wide. And the highlighting is done by simply disabling reverse-video for that 1 character, it was the simplest I could think of. Hannes