From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Linux native thread create/exit events support
Date: Mon, 23 May 2016 13:00:00 -0000 [thread overview]
Message-ID: <31847d5c-7b3d-9542-e28a-ec69cd04689c@redhat.com> (raw)
In-Reply-To: <86posd6odr.fsf@gmail.com>
On 05/23/2016 11:48 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
> Patch is good to me, one question below,
>
>> - /* This was the last lwp in the process. Since events are
>> + /* This may be the last lwp in the process. Since events are
>> serialized to GDB core, we may not be able report this one
>> right now, but GDB core and the other target layers will want
>> to be notified about the exit code/signal, leave the status
>
> Is this paragraph of comment still valid?
Indeed, doesn't look like it adds much now. I'll remove it.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-05-23 13:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 14:48 [PATCH 0/6] Fix PR gdb/19828 (attach -> internal error) and attach optimizations Pedro Alves
2016-05-19 14:48 ` [PATCH 1/6] Linux native thread create/exit events support Pedro Alves
2016-05-23 10:49 ` Yao Qi
2016-05-23 13:00 ` Pedro Alves [this message]
2016-05-19 14:48 ` [PATCH 2/6] [Linux] Read vDSO range from /proc/PID/task/PID/maps instead of /proc/PID/maps Pedro Alves
2016-05-23 11:08 ` Yao Qi
2016-05-19 14:48 ` [PATCH 3/6] [Linux] Avoid refetching core-of-thread if thread hasn't run Pedro Alves
2016-05-23 12:45 ` Yao Qi
2016-05-19 14:56 ` [PATCH 5/6] Make gdb/linux-nat.c consider a waitstatus pending on the infrun side Pedro Alves
2016-05-19 14:57 ` [PATCH 6/6] Fix PR gdb/19828: gdb -p <process from a container>: internal error Pedro Alves
2016-05-23 10:14 ` Yao Qi
2016-05-25 17:43 ` [pushed/7.11.1] " Pedro Alves
2016-05-19 14:57 ` [PATCH 4/6] [Linux] Optimize PID -> struct lwp_info lookup Pedro Alves
2016-05-23 13:12 ` Yao Qi
2016-05-23 18:10 ` [PATCH v2/htab " Pedro Alves
2016-05-24 9:33 ` Yao Qi
2016-05-24 13:47 ` Pedro Alves
2016-05-19 15:11 ` [PATCH 0/6] Fix PR gdb/19828 (attach -> internal error) and attach optimizations Pedro Alves
2016-05-24 13:57 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31847d5c-7b3d-9542-e28a-ec69cd04689c@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).