From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88123 invoked by alias); 23 May 2016 13:00:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88104 invoked by uid 89); 23 May 2016 13:00:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*F:U*palves X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 May 2016 13:00:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38237627DB; Mon, 23 May 2016 13:00:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4ND0jvQ023186; Mon, 23 May 2016 09:00:46 -0400 Subject: Re: [PATCH 1/6] Linux native thread create/exit events support To: Yao Qi References: <1463669290-30415-1-git-send-email-palves@redhat.com> <1463669290-30415-2-git-send-email-palves@redhat.com> <86posd6odr.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <31847d5c-7b3d-9542-e28a-ec69cd04689c@redhat.com> Date: Mon, 23 May 2016 13:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <86posd6odr.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00385.txt.bz2 On 05/23/2016 11:48 AM, Yao Qi wrote: > Pedro Alves writes: > > Patch is good to me, one question below, > >> - /* This was the last lwp in the process. Since events are >> + /* This may be the last lwp in the process. Since events are >> serialized to GDB core, we may not be able report this one >> right now, but GDB core and the other target layers will want >> to be notified about the exit code/signal, leave the status > > Is this paragraph of comment still valid? Indeed, doesn't look like it adds much now. I'll remove it. Thanks, Pedro Alves