From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118421 invoked by alias); 26 Jun 2017 12:47:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118377 invoked by uid 89); 26 Jun 2017 12:47:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=dept, famous X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 12:47:41 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31E9F80465; Mon, 26 Jun 2017 12:47:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 31E9F80465 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 31E9F80465 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5991A7E4A0; Mon, 26 Jun 2017 12:47:39 +0000 (UTC) Subject: Re: [PATCH 2/3] vec: Silence -Wunused-function warnings on clang To: Simon Marchi References: <1498412703-24303-1-git-send-email-simon.marchi@ericsson.com> <1498412703-24303-3-git-send-email-simon.marchi@ericsson.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <31ac014f-ea44-020f-d999-5bee4dd8293f@redhat.com> Date: Mon, 26 Jun 2017 12:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00700.txt.bz2 On 06/26/2017 01:28 PM, Simon Marchi wrote: > I wanted to keep it simple and easy to understand, so I didn't want to > add to many layers of definitions. I thought that even if we ignored > -Wunused-function in the vector macro expansions when compiling with > GCC, it wasn't a big deal. That's another option (and I think it should be fine, with a comment), but it wasn't what the patch was doing, so you'd be leaving deciding whether that's fine to whoever comes next and wants to make DIAGNOSTICS_IGNORE_UNUSED_FUNCTION on gcc. IMO, that's a form of technical dept that we should avoid. The point here I'm trying to convey is: avoid letting the specifics of users of the DIAGNOSTICS_IGNORE users bleed into the conditionals that are used to define the macros in diagnostics.h. At least for the macros that map directly to the warning name. > But 2.2 is fine with me, I'll try it. It's > all temporary anyway (famous last words), since the days of vec.h are > counted :). True. :-) Thanks, Pedro Alves