From: John Baldwin <jhb@FreeBSD.org>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct
Date: Sat, 5 Jun 2021 14:20:17 -0700 [thread overview]
Message-ID: <31bde046-a86f-9995-545d-a03737cf493b@FreeBSD.org> (raw)
In-Reply-To: <20210605001427.3597687-2-pedro@palves.net>
On 6/4/21 5:14 PM, Pedro Alves wrote:
> diff --git a/gdb/nat/amd64-linux-siginfo.c b/gdb/nat/amd64-linux-siginfo.c
> index e2d2db6e112..9ff9361487a 100644
> --- a/gdb/nat/amd64-linux-siginfo.c
> +++ b/gdb/nat/amd64-linux-siginfo.c
> @@ -206,7 +206,7 @@ typedef struct compat_siginfo
> /* For x32, clock_t in _sigchld is 64bit aligned at 4 bytes. */
> typedef long __attribute__ ((__aligned__ (4))) compat_x32_clock_t;
>
> -typedef struct compat_x32_siginfo
> +typedef struct __attribute__ ((__aligned__ (8))) compat_x32_siginfo
> {
> int si_signo;
> int si_errno;
> @@ -263,7 +263,7 @@ typedef struct compat_x32_siginfo
> int _fd;
> } _sigpoll;
> } _sifields;
> -} compat_x32_siginfo_t __attribute__ ((__aligned__ (8)));
> +} compat_x32_siginfo_t;
>
> /* To simplify usage of siginfo fields. */
Looks good to me. Note that alignas() is part of C++11, so you could
perhaps spell this a bit shorter as "alignas (8)" instead.
--
John Baldwin
next prev parent reply other threads:[~2021-06-05 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:14 [PATCH 0/2] Fix alignment issue flagged by Clang in nat/amd64-linux-siginfo.c Pedro Alves
2021-06-05 0:14 ` [PATCH 1/2] nat/amd64-linux-siginfo.c: Move align attribute from typedef to struct Pedro Alves
2021-06-05 21:20 ` John Baldwin [this message]
2021-06-07 22:20 ` Pedro Alves
2021-06-07 22:42 ` John Baldwin
2021-06-05 0:14 ` [PATCH 2/2] nat/amd64-linux-siginfo.c: Remove typedefs Pedro Alves
2021-06-06 14:41 ` [PATCH 0/2] Fix alignment issue flagged by Clang in nat/amd64-linux-siginfo.c Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31bde046-a86f-9995-545d-a03737cf493b@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).