From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@freebsd.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Fix mismatched struct vs class tags.
Date: Wed, 30 Nov 2016 11:39:00 -0000 [thread overview]
Message-ID: <31fa3dbd-e1d1-1fd2-7774-8bc82fd8b37d@redhat.com> (raw)
In-Reply-To: <1573845.CKxfuZpZBq@ralph.baldwin.cx>
On 11/24/2016 07:15 PM, John Baldwin wrote:
> On Thursday, November 24, 2016 06:50:30 PM Pedro Alves wrote:
>> On 11/24/2016 05:45 PM, John Baldwin wrote:
>>
>>> Ok. At the moment we don't have a clang-specific warning set, but if we
>>> add one we can add this to that.
>>
>> We likely don't need one. Our infrustruture checks whether a
>> warning works before enabling it. See gdb/warning.m4.
>
> Hmmm. The only odd case I can think of is -Wunused-function. Right now
> clang triggers warnings when VEC() is used, so ideally -Wunused-function
Yeah, I still believe that's a clang bug, and clang developers
seem to agree:
https://llvm.org/bugs/show_bug.cgi?id=22712
> would only be present for GCC and not for clang. I can look at adding
> other -Wno-foo warnings for clang things we wish to ignore however.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-11-30 11:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 20:07 [PATCH 0/3] Fix various C++ related clang warnings John Baldwin
2016-11-23 20:08 ` [PATCH 2/3] Add noexcept to custom non-throwing new operators John Baldwin
2016-11-24 17:03 ` Pedro Alves
2016-11-23 20:08 ` [PATCH 3/3] Do not use std::move when assigning an anonymous object to a unique_ptr John Baldwin
2016-11-23 21:19 ` Simon Marchi
2016-11-23 23:31 ` John Baldwin
2016-11-24 0:08 ` Simon Marchi
2016-11-24 16:52 ` Pedro Alves
2016-11-23 20:08 ` [PATCH 1/3] Fix mismatched struct vs class tags John Baldwin
2016-11-23 20:58 ` Simon Marchi
2016-11-23 23:23 ` John Baldwin
2016-11-24 17:02 ` Pedro Alves
2016-11-24 17:47 ` John Baldwin
2016-11-24 18:50 ` Pedro Alves
2016-11-24 19:15 ` John Baldwin
2016-11-30 11:39 ` Pedro Alves [this message]
2016-11-30 16:23 ` John Baldwin
2016-11-30 16:38 ` Pedro Alves
2016-11-30 16:52 ` Simon Marchi
2016-11-30 16:51 ` Simon Marchi
2016-11-30 17:08 ` Pedro Alves
2016-11-30 17:54 ` Simon Marchi
2016-11-30 17:59 ` Eli Zaretskii
2016-11-23 22:18 ` [PATCH 0/3] Fix various C++ related clang warnings Simon Marchi
2016-11-23 23:23 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31fa3dbd-e1d1-1fd2-7774-8bc82fd8b37d@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).