From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00088.outbound.protection.outlook.com [40.107.0.88]) by sourceware.org (Postfix) with ESMTPS id BFD643858C52; Mon, 4 Apr 2022 08:02:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFD643858C52 Received: from DU2PR04CA0359.eurprd04.prod.outlook.com (2603:10a6:10:2b4::26) by DBAPR08MB5686.eurprd08.prod.outlook.com (2603:10a6:10:1a1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 08:02:01 +0000 Received: from DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b4:cafe::d7) by DU2PR04CA0359.outlook.office365.com (2603:10a6:10:2b4::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31 via Frontend Transport; Mon, 4 Apr 2022 08:02:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT035.mail.protection.outlook.com (10.152.20.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19 via Frontend Transport; Mon, 4 Apr 2022 08:02:00 +0000 Received: ("Tessian outbound 62985e3c34b6:v118"); Mon, 04 Apr 2022 08:02:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1deb13d672049bfb X-CR-MTA-TID: 64aa7808 Received: from 936a7909edc4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9CB4AF3C-DE66-43E9-9F44-B9ED46557B2C.1; Mon, 04 Apr 2022 08:01:53 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 936a7909edc4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Apr 2022 08:01:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZltDUE5yxPuDzXpQoZ6FjBCrUhys0Wk+G9/RePfQCZOzohSRFIK2L1Q2K0XNY1oGn5zv99kzvegmqP2GrqRRnt9gwzgOU2+ksaXUwTTxbJFN/x4nknEFcNdj9QKmYtVFTJVl7BrcftHjOLyHCL9hB0cn119GHga4DB3SB8zzLWujsD1f3iDbkNXbRquaDPSfM9QIQjqAIv/AWBDDKJGiPb3QqbJUYRHGRYYvDn7AN9pSfZ1d6lGQAFGG57G4gSWCwCodPHc1gXB38dFf8sJSqKkYSZdPSZf1/40HOTWWb5Vzj9i0jC4PjTf5F+xVs7RQNBt1qu5tfFx8b1QfyWk4eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s16U1kfd2BJZ1w2+2ZDATNoDTS9J0GiZtKJQYbuw+zA=; b=jZdMUqpj8dC6pwdblEm7z4inbQh+pDHYPqLn4hUAJyRN+GCOZCNn2uLuT43Qjl4YR0aJ9T+sXnEz43mqlyiqUf41TJEOdKws5RAylWxE47+2EyyNteZ/hxTl+rx1oaoEucBqu/orUDeBBbC+YdCKoja1wIPf+38nKICW1jtt46NaLcP6bnFkoyfNDlnQMi50iCfm9mIzLUmNLqcdEelE396mMQxOk9R+cFe1e/sQVMq3EuCniw26QY8d94tZ7remg4H0jaXNtcIYdFnKXfdOGfSHsDHVPznaj/dvWmU9DrVE9f5siWLHXdRjoVYLdiWxWhVJwnDdTNV8+aDKmrwC+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB7720.eurprd08.prod.outlook.com (2603:10a6:20b:508::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 08:01:52 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 08:01:52 +0000 Message-ID: <31fefe5b-4fe5-3e3b-5eeb-b1328c584916@arm.com> Date: Mon, 4 Apr 2022 09:01:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 04/12] Add an arm-tls feature which includes the tpidruro register from CP15. Content-Language: en-US To: John Baldwin , binutils@sourceware.org, gdb-patches@sourceware.org References: <20220323210048.25525-1-jhb@FreeBSD.org> <20220323210048.25525-5-jhb@FreeBSD.org> From: Luis Machado In-Reply-To: <20220323210048.25525-5-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0032.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::19) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: eeeb63ac-6724-496d-74ed-08da16116622 X-MS-TrafficTypeDiagnostic: AS8PR08MB7720:EE_|DB5EUR03FT035:EE_|DBAPR08MB5686:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: T/PyEA7f7dfgJQF3Rb8DcOL9ZjNJS5PiePYZEm14/lej9IF3izWeTMXrd2qSXbVBZ0hkQvAI2CUqnQYBrstGhVJLp27U6Nk8bDOOQI8l3VgEkPIErarfRC5iliPLKxdpI5csO1MJ4SEXWPGr5QUEebIz9scfbvmENHMV/VTTZGRNvbB1EWi2g2GaqhyeC5FpU941d9qfvKX+87CDjPe/0czd2q/j/bqMqnCtfiEl2NV8Orh+4oHTTG0O/B3l25W3h6Dx8CyB1M+g1XXKAixyh8PKMbkCNesMgYgiqnV00TnmJ0a1dv0MRpPF7/bVAU0qzY7zzvPplokBnFMX/6riEV2DFaWwDQNC5rF5JOstJ4q1A8Go3Ezc23gyEK5caB0xwZYzk+LutqqGpslH0yTwxA1YWHNOtDgy0fUCQpsLvMmN1dRVqF0mbZxb1dDm5Vagn7pIBKEbL07OvVV/rKM7KEPwYgEaPGETFxg9O/zL0xgKMF8CPBKXr9RoEjrP11LXbX+Sbzgc+t8kJYg0pv4dw8Z4tjJkwbJl39gcLe3LoTUCCoob7Vk/4wvNM4URyWhV1FHhLgkT40uIRds4sl09IdeuCY3SX45EmF9WWN7k/SAtBNPrI1KgttPBIkbUg8wSx2sPLJk+Y615vB2kOyJZ9uRjZNmz8W6LjiiqXLmUfbfXIr3tDWwQoYQ5Cfk8VbIBSfboS4dWwZOdfyxGFyGDqWSlfXMMxHWZ9EVmeQaQPTQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(6506007)(6512007)(508600001)(53546011)(2616005)(26005)(186003)(83380400001)(86362001)(6486002)(38100700002)(5660300002)(31686004)(2906002)(44832011)(31696002)(36756003)(8676002)(8936002)(66946007)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7720 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5cbca5f6-3069-4ccf-5b57-08da161160dc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RiTLrJM0VAoBtz1DPO4JTyUgJPgcxS4BblQTJrR5krnG65p66jyGNTl3/h43U1FqTnUQtz8ggg1jXHMYA8ElkVlPkOR9tTUe9aGFzsWg4QMxbxd0JvzNFtgrZOsyGkq6ta/b6o0+hTvdEKJZ4mGDHfkat+8hlJnvzGO9bxNtmOGhv1Z973ExelvBAttUwSKjFM9fQQHCHVOy2bmMHy0B8FNpL6EootWTNJmTSE0kHsQ51qGHHlVi0Utz+Zdn6CxqjVbw+HK2tx30cWjbREDxcgSFguG/uS9O5JSs2PqW4nE1nvLGGisaiX66v4/9xxYqmV7BYqM+z8yF9FwTEgHd/BxI/HefPXTGFsG7B6JNKrDvSZbpwub44xkMM0wng4Pqs8pdNNy443jWrh19YA78c8eG8fY5H415qsxygmN5GoHfB3km6vfj3zHJ/yChaEuaTPy8Ho09xRg+1jUzI34IkOsokmpUFPAtq5EGb8taIKT74s35j7TeGLYD9iTu+vYnHQgR309Xicxb6//Va9AHhO9MKwBZs86p0nWUCsAf679VFykm2vidSr0I7f4/2Djew4MtgOuve1+ModcULnqgWdfvosslfNt4IznTJJPOmgSpbMb5ck6fSz5ycGS4YsTQzG6PN1AUlRpbeh/Aaj8eU226kNUw/DA87gOVvcyh6QltbBPzpDo/nP/y4kGFtfzd X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(2906002)(31696002)(47076005)(70206006)(336012)(508600001)(86362001)(82310400004)(450100002)(6486002)(2616005)(8936002)(44832011)(186003)(81166007)(36756003)(5660300002)(6506007)(31686004)(8676002)(70586007)(53546011)(6512007)(36860700001)(83380400001)(356005)(316002)(26005)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2022 08:02:00.9979 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eeeb63ac-6724-496d-74ed-08da16116622 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5686 X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 08:02:06 -0000 Hi, On 3/23/22 21:00, John Baldwin wrote: > --- > gdb/arch/aarch32.c | 2 ++ > gdb/arch/arm.c | 6 +++++- > gdb/arch/arm.h | 7 ++++--- > gdb/arm-fbsd-tdep.c | 4 ++-- > gdb/arm-linux-nat.c | 6 +++--- > gdb/arm-linux-tdep.c | 4 ++-- > gdb/arm-netbsd-nat.c | 4 ++-- > gdb/arm-tdep.c | 20 +++++++++++++++----- > gdb/arm-tdep.h | 2 +- > gdb/features/Makefile | 1 + > gdb/features/arm/arm-tls.c | 14 ++++++++++++++ > gdb/features/arm/arm-tls.xml | 11 +++++++++++ > 12 files changed, 62 insertions(+), 19 deletions(-) > create mode 100644 gdb/features/arm/arm-tls.c > create mode 100644 gdb/features/arm/arm-tls.xml > > diff --git a/gdb/arch/aarch32.c b/gdb/arch/aarch32.c > index 0c544d381f1..4d6ffb44a15 100644 > --- a/gdb/arch/aarch32.c > +++ b/gdb/arch/aarch32.c > @@ -19,6 +19,7 @@ > #include "aarch32.h" > > #include "../features/arm/arm-core.c" > +#include "../features/arm/arm-tls.c" > #include "../features/arm/arm-vfpv3.c" > > /* See aarch32.h. */ > @@ -38,6 +39,7 @@ aarch32_create_target_description () > /* Create a vfpv3 feature, then a blank NEON feature. */ > regnum = create_feature_arm_arm_vfpv3 (tdesc.get (), regnum); > tdesc_create_feature (tdesc.get (), "org.gnu.gdb.arm.neon"); > + regnum = create_feature_arm_arm_tls (tdesc.get (), regnum); > > return tdesc.release (); > } > diff --git a/gdb/arch/arm.c b/gdb/arch/arm.c > index 126e46a950a..15b600e22f4 100644 > --- a/gdb/arch/arm.c > +++ b/gdb/arch/arm.c > @@ -22,6 +22,7 @@ > #include "arm.h" > > #include "../features/arm/arm-core.c" > +#include "../features/arm/arm-tls.c" > #include "../features/arm/arm-vfpv2.c" > #include "../features/arm/arm-vfpv3.c" > #include "../features/arm/xscale-iwmmxt.c" > @@ -373,7 +374,7 @@ shifted_reg_val (struct regcache *regcache, unsigned long inst, > /* See arch/arm.h. */ > > target_desc * > -arm_create_target_description (arm_fp_type fp_type) > +arm_create_target_description (arm_fp_type fp_type, bool tls) > { > target_desc_up tdesc = allocate_target_description (); > > @@ -409,6 +410,9 @@ arm_create_target_description (arm_fp_type fp_type) > error (_("Invalid Arm FP type: %d"), fp_type); > } > > + if (tls) > + regnum = create_feature_arm_arm_tls (tdesc.get (), regnum); > + > return tdesc.release (); > } > > diff --git a/gdb/arch/arm.h b/gdb/arch/arm.h > index f75470e7572..32f29b20d33 100644 > --- a/gdb/arch/arm.h > +++ b/gdb/arch/arm.h > @@ -49,6 +49,7 @@ enum gdb_regnum { > ARM_D0_REGNUM, /* VFP double-precision registers. */ > ARM_D31_REGNUM = ARM_D0_REGNUM + 31, > ARM_FPSCR_REGNUM, > + ARM_TPIDRURO_REGNUM, > > /* Other useful registers. */ > ARM_FP_REGNUM = 11, /* Frame register in ARM code, if used. */ > @@ -65,8 +66,8 @@ enum arm_register_counts { > ARM_NUM_ARG_REGS = 4, > /* Number of floating point argument registers. */ > ARM_NUM_FP_ARG_REGS = 4, > - /* Number of registers (old, defined as ARM_FPSCR_REGNUM + 1. */ > - ARM_NUM_REGS = ARM_FPSCR_REGNUM + 1 > + /* Number of registers (old, defined as ARM_TPIDRURO_REGNUM + 1. */ > + ARM_NUM_REGS = ARM_TPIDRURO_REGNUM + 1 > }; I'm attempting to move away from these hardcoded register numbers. If there are optional features, that means ARM_NUM_REGS won't reflect the reality anymore, and there may be holes in the register numbering. For example, a bare metal target may not have ARM_TPIDRURO_REGNUM. The correct way is to account for it dynamically, similar to what we do with MVE (and to what we do for pauth, MTE and your TLS handling).