From: Pedro Alves <palves@redhat.com>
To: Weimin Pan <weimin.pan@oracle.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Unbreak gdb build on 32-bit host with ADI support
Date: Thu, 31 Aug 2017 08:31:00 -0000 [thread overview]
Message-ID: <321a5c87-893a-a176-cc4b-b13ba9dc5730@redhat.com> (raw)
In-Reply-To: <1503707605-65627-1-git-send-email-weimin.pan@oracle.com>
Hi Weimin,
> +2017-08-25 Weimin Pan <weimin.pan@oracle.com>
> +
> + * sparc64-tdep.c: Unbreak gdb build on 32-bit host with ADI support.
> +
In the GNU ChangeLog format, this should say which functions were touched,
and what was changed, as opposed to "why" things were changed. Please take a
look here to learn more about this:
https://sourceware.org/gdb/wiki/ContributionChecklist
You actually already had the right info in the commit log, so I cooked up
an entry for you, and pushed the patch in with that:
2017-08-31 Weimin Pan <weimin.pan@oracle.com>
* sparc64-tdep.c (adi_stat_t): Fix comment formatting.
(adi_available): Use a temp variable of type CORE_ADDR as argument
3 when calling target_auxv_search.
(adi_normalize_address): Use masks and xor operators to calculate
normalized address.
(adi_read_versions, adi_write_versions, adi_print_versions)
(do_examine, do_assign): Use paddress.
Thanks for the patch.
Pedro Alves
next prev parent reply other threads:[~2017-08-31 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-26 0:44 Weimin Pan
2017-08-30 19:01 ` ping: " Jan Kratochvil
2017-08-31 8:31 ` Pedro Alves [this message]
2017-08-31 16:35 ` Wei-min Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=321a5c87-893a-a176-cc4b-b13ba9dc5730@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).