From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 4408E385842C for ; Wed, 7 Jun 2023 13:12:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4408E385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 717A81FDAC; Wed, 7 Jun 2023 13:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLt+ve+bVvsDzITxqFvuXEHqUQ0WIDjaVj2QwbRKMZs=; b=V3S4WVa87ABI+XnKEIvgu3n/Z9e25gB5Hm1/xfZ6Oq/Q91CMgJqx2ohWzSRUldQWtthf7Q 0/HKnI+BnbtfQx6jerId8BxO2ZodZxvi14ZRH4Pt2c2pxusLQXpPyeZCfrbQByxIQaZqid afxOFAVNZenEiJ0/Uo9mn0TVnbeI3GQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLt+ve+bVvsDzITxqFvuXEHqUQ0WIDjaVj2QwbRKMZs=; b=3h7XBBmrnnrd+JLDMlPNsMJqKVCxNMu2bvRXt7r8JPHDW/t6Q+BTfnxBK01rSnQTl2OE3k rOlHimeobZDJ0FBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 557BC1346D; Wed, 7 Jun 2023 13:12:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LA0+E0SCgGSCXwAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:12:36 +0000 Message-ID: <32342148-1eee-fe1b-ba20-97e7f18f6648@suse.de> Date: Wed, 7 Jun 2023 15:12:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] [gdb/tui] Factor out border-mode help text Content-Language: en-US To: gdb-patches@sourceware.org Cc: Tom Tromey References: <20230521195933.5351-1-tdevries@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/22/23 11:09, Tom de Vries via Gdb-patches wrote: > On 5/21/23 21:59, Tom de Vries via Gdb-patches wrote: >> I noticed that the help texts for tui border-mode and tui >> active-border-mode >> are similar. >> >> Factor out the common part into macro HELP_ATTRIBUTE_MODE. >> > > This is a v2, which uses c++ std::string instead of a macro. > > OTOH, it changes the translation boundaries, and I'm not sure if the new > parts still classify as "entire sentence". > > Then again, I was not able to find any files containing translations for > gdb, so perhaps it doesn't matter. As there are no comments on these issues sofar, I've committed v1. Thanks, - Tom