From: Luis Machado <lgustavo@codesourcery.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
<gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Add native support for Linux SH
Date: Mon, 13 Feb 2017 18:57:00 -0000 [thread overview]
Message-ID: <3264a34b-0036-09e9-09f8-50d8188b7d00@codesourcery.com> (raw)
In-Reply-To: <20170210205546.7982-2-glaubitz@physik.fu-berlin.de>
Hi John,
Thanks for the patch.
It would be nice to have the patch split into more manageable/logical
bits. It would make it both easier and quicker to review.
For example, splitting gdb/testsuite, gdb/config, Makefile/configure,
native (sh-linux-nat) and potentially sh-tdep and sh-linux changes into
their own patches.
Regards,
Luis
On 02/10/2017 02:55 PM, John Paul Adrian Glaubitz wrote:
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> ---
> gdb/Makefile.in | 2 +
> gdb/config/sh/linux.mh | 14 +
> gdb/config/sh/nm-linux.h | 54 ++++
> gdb/config/sh/xm-linux.h | 32 +++
> gdb/configure.host | 1 +
> gdb/sh-linux-nat.c | 268 ++++++++++++++++++
> gdb/sh-linux-tdep.c | 516 +++++++++++++++++++++++++++++++++++
> gdb/sh-tdep.c | 54 ++--
> gdb/sh-tdep.h | 53 +++-
> gdb/testsuite/gdb.asm/asm-source.exp | 5 +
> gdb/testsuite/gdb.asm/sh-linux.inc | 78 ++++++
> gdb/testsuite/gdb.asm/sh.inc | 3 +-
> 12 files changed, 1049 insertions(+), 31 deletions(-)
> create mode 100644 gdb/config/sh/linux.mh
> create mode 100644 gdb/config/sh/nm-linux.h
> create mode 100644 gdb/config/sh/xm-linux.h
> create mode 100644 gdb/sh-linux-nat.c
> create mode 100644 gdb/testsuite/gdb.asm/sh-linux.inc
next prev parent reply other threads:[~2017-02-13 18:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 21:03 RFC: " John Paul Adrian Glaubitz
2017-02-10 21:03 ` [PATCH] gdb: " John Paul Adrian Glaubitz
2017-02-13 18:57 ` Luis Machado [this message]
2017-02-13 18:59 ` John Paul Adrian Glaubitz
2017-02-10 21:06 ` RFC: " John Paul Adrian Glaubitz
2017-02-13 22:27 ` Yao Qi
2017-02-13 22:31 ` John Paul Adrian Glaubitz
2017-02-16 21:48 ` Yao Qi
2017-02-18 12:32 ` John Paul Adrian Glaubitz
2017-02-18 20:07 ` Yao Qi
2017-03-10 10:50 ` Yao Qi
2017-03-10 10:53 ` John Paul Adrian Glaubitz
2017-06-12 12:15 ` John Paul Adrian Glaubitz
2017-06-12 14:15 ` Yao Qi
2017-02-16 19:02 ` Mike Frysinger
2018-06-21 9:49 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3264a34b-0036-09e9-09f8-50d8188b7d00@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=glaubitz@physik.fu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).