From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129736 invoked by alias); 13 Feb 2017 18:57:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129720 invoked by uid 89); 13 Feb 2017 18:57:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=516, sk:glaubit, D*fu-berlin.de, glaubitz@physik.fu-berlin.de X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Feb 2017 18:57:32 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cdLoY-0005Hn-7t from Luis_Gustavo@mentor.com ; Mon, 13 Feb 2017 10:57:30 -0800 Received: from [172.30.12.49] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 13 Feb 2017 10:57:27 -0800 Subject: Re: [PATCH] gdb: Add native support for Linux SH References: <20170210205546.7982-1-glaubitz@physik.fu-berlin.de> <20170210205546.7982-2-glaubitz@physik.fu-berlin.de> To: John Paul Adrian Glaubitz , Reply-To: Luis Machado From: Luis Machado Message-ID: <3264a34b-0036-09e9-09f8-50d8188b7d00@codesourcery.com> Date: Mon, 13 Feb 2017 18:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170210205546.7982-2-glaubitz@physik.fu-berlin.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00361.txt.bz2 Hi John, Thanks for the patch. It would be nice to have the patch split into more manageable/logical bits. It would make it both easier and quicker to review. For example, splitting gdb/testsuite, gdb/config, Makefile/configure, native (sh-linux-nat) and potentially sh-tdep and sh-linux changes into their own patches. Regards, Luis On 02/10/2017 02:55 PM, John Paul Adrian Glaubitz wrote: > Signed-off-by: John Paul Adrian Glaubitz > --- > gdb/Makefile.in | 2 + > gdb/config/sh/linux.mh | 14 + > gdb/config/sh/nm-linux.h | 54 ++++ > gdb/config/sh/xm-linux.h | 32 +++ > gdb/configure.host | 1 + > gdb/sh-linux-nat.c | 268 ++++++++++++++++++ > gdb/sh-linux-tdep.c | 516 +++++++++++++++++++++++++++++++++++ > gdb/sh-tdep.c | 54 ++-- > gdb/sh-tdep.h | 53 +++- > gdb/testsuite/gdb.asm/asm-source.exp | 5 + > gdb/testsuite/gdb.asm/sh-linux.inc | 78 ++++++ > gdb/testsuite/gdb.asm/sh.inc | 3 +- > 12 files changed, 1049 insertions(+), 31 deletions(-) > create mode 100644 gdb/config/sh/linux.mh > create mode 100644 gdb/config/sh/nm-linux.h > create mode 100644 gdb/config/sh/xm-linux.h > create mode 100644 gdb/sh-linux-nat.c > create mode 100644 gdb/testsuite/gdb.asm/sh-linux.inc