From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 7E9B93888C7F for ; Mon, 12 Jul 2021 15:11:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E9B93888C7F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 5D98D98B47; Mon, 12 Jul 2021 15:11:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GNnKn1Mc0z4Vks; Mon, 12 Jul 2021 15:11:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (d-24-233-223-154.va.cpe.atlanticbb.net [24.233.223.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id E03BDEFEC; Mon, 12 Jul 2021 15:11:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [RFC PATCH 5/7] fbsd nat: Include ptrace operation in error messages. To: Pedro Alves , gdb-patches@sourceware.org References: <20210607170932.3954-1-jhb@FreeBSD.org> <20210607170932.3954-6-jhb@FreeBSD.org> <0671aafc-a993-2f2f-aaed-00468d5d3bec@palves.net> From: John Baldwin Message-ID: <326b9fb7-e937-0512-7341-f9509e80f16d@FreeBSD.org> Date: Mon, 12 Jul 2021 11:11:40 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <0671aafc-a993-2f2f-aaed-00468d5d3bec@palves.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jul 2021 15:11:42 -0000 On 6/27/21 9:13 AM, Pedro Alves wrote: > On 2021-06-07 6:09 p.m., John Baldwin wrote: >> - perror_with_name (("ptrace")); >> + perror_with_name (_("ptrace (PT_GET_EVENT_MASK)")); > > Note that the missing _ was not a typo -- it's there to silence ARI warnings > about missing i18n when the string has nothing to translate. Hmm, the new strings probably don't have anything to translate either, so I should probably add the _ back? -- John Baldwin