From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 6BEA03858428 for ; Mon, 21 Aug 2023 16:10:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BEA03858428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RTyBf0kmYz4hVP; Mon, 21 Aug 2023 16:10:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RTyBf02Vqz4PRy; Mon, 21 Aug 2023 16:10:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692634250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1auBEofFMvj4xeh2Ztm555wS4+ieBxd0TnGntwnMqIY=; b=Fm37VSAnJdBT9VkipY9FUoEgpCRwaKIgQSvQHgW2/jeIHnCUa6GtyIPehtEAE/4SKX9ujt m68J6nwfYAZpTmLkwAkkYiOqRhJvksjz+6MOxemLXljwYkwlppl9EyDxwloDXgFrsstt5m 2PkMHsc4ff5654Gkp0mS0XfiXLZw/pEDxrd/n9fFF9k7/5JAyP8tt5YVa7E1EMlE/vx43B pXtjvMipz542NUWcVpf8ZVRfy9jsjClX+57NFslkIn3i9k99n2Aj7yOg5QH7T4Bkk9FV4n nM2qmeSlPd3GZOtq5oHtYBdOQ+yQ6HfOsD45l19DwYdNmVWfmOSi2aHAJ6h+dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692634250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1auBEofFMvj4xeh2Ztm555wS4+ieBxd0TnGntwnMqIY=; b=ivFT4vjAQ15BumeUFFqjhpNP5m/9WLznZ127qdHtFtg+aQUEKTB9Md98gsS4oUbp5heHWp KVfOFSyUAKKAFspQlvG1U41DZKYdIMQF9CLUtRShVqtwdl+HjYaq5bo+wyOkcxayMMMb5K AuzFF3ooLDnJJ3kwFyl8fX7qrgawC5beSqWkKQ5QHD8jQqtnqBABoGhaC8ECv8ve+/fAy1 NeQDfdpCeNKEfvIjT6OV/fjmmG8kELm1pLpIJuzqOlEkHe5WUIVk/OlZ7WJ4UbpnkGT/pw JVMojBl/SRJagy0gd1y7EV3g9Fy2nYzTe5sCIEqz8T418RM/P54yHQzqYJexCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692634250; a=rsa-sha256; cv=none; b=GjNNDb6L9r13pYLjtbAUXALRR2laAQN6dt0qzCA/Bbc82upF8DoZhIthdUFQfEsF3BEiZH w7vY+1zKeihApMO89jqhJJu2Fyf99qDrJIkKewXZaqsBbTE4Qg6wfpwuge3ysvtX1TQDCC d+dmSw3LKUaJnl9AU+u0QvUz7Yfr9geEdNAeoT5cOd47/F5UjLGB9jJsV/ZcKRoClgHfEs p5JG2xoUv5p0kMBa4i2slf7FZjf8CtnLHBOqXj2xA45LxBTIJhwHAnDkJ+xBt/fx4FT1aG GTCypN6TwTXZ8h2+2p8wKGkkUp/8OK+CMy964Fy3N+OOMBZ+ITx/gx1/VvcMZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:648:8683:a9e0:7c3a:7be7:4d69:1394] (unknown [IPv6:2601:648:8683:a9e0:7c3a:7be7:4d69:1394]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RTyBd2lssz9VP; Mon, 21 Aug 2023 16:10:49 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <327aa847-c856-5644-af0e-640151694fb1@FreeBSD.org> Date: Mon, 21 Aug 2023 09:10:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org Cc: Pedro Alves References: From: John Baldwin Subject: Re: [PATCH 0/3] Fix thread exited messages for remote targets In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/21/23 2:31 AM, Andrew Burgess via Gdb-patches wrote: > The point of this series is to fix the thread ... exited messages for > remote targets. I made a previous attempt to fix this issue: > > https://inbox.sourceware.org/gdb-patches/0215c520c680334efac7f0544d834ec1fb7aff8e.1669634536.git.aburgess@redhat.com/ > https://inbox.sourceware.org/gdb-patches/d6d49338119d2a32e060f95219aacac31bdf4886.1674207665.git.aburgess@redhat.com/ > > But Pedro hinted that he had a better solution as part of his step > over clone/exit work, the latest version of which can be found here: > > https://inbox.sourceware.org/gdb-patches/20221212203101.1034916-31-pedro@palves.net/ > > Unfortunately, the larger series, of which that commit is a part, > seems to have stalled. However, that particular patch doesn't really > depend on anything else in the series, and so, in this series I've > pulled out this one patch (3/3), along with one other patch on which > the above sort-of depended (1/3 - this changes a similar area of GDB). > > The remaining patch (2/3) is my own work, and is an additional > refactor which I think follows naturally from the first patch. > > Patches #1 and #3 are mostly Pedro's work, though, some updates were > needed during the rebase. Any bugs introduced by the rebase are mine. Thanks for this cleanup. The asymmetry of what targets had to do here was kind of odd. One question I have is why is the optional metadata specifically a ULONGEST exit code rather than just a std::string suffix? If it were a string then windows-nat.c could use something like: std::string info = string_printf ("with code %u", (unsigned) exit_code). delete_thread_with_info (to_del, info, silent); -- John Baldwin