From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 81E9838582A1 for ; Thu, 21 Jul 2022 12:38:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 81E9838582A1 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 218EB1E13B; Thu, 21 Jul 2022 08:38:20 -0400 (EDT) Message-ID: <32c2cd35-9303-2a3d-64f2-c4106bfdf6e2@simark.ca> Date: Thu, 21 Jul 2022 08:38:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 08/29] Thread options & clone events (native Linux) Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> <20220713222433.374898-9-pedro@palves.net> From: Simon Marchi In-Reply-To: <20220713222433.374898-9-pedro@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 12:38:22 -0000 On 2022-07-13 18:24, Pedro Alves wrote: > This commit teaches the native Linux target about the GDB_TO_CLONE > thread option. It's actually simpler to just continue reporting all > clone events unconditionally to the core. There's never any harm in > reporting a clone event when the option is disabled. All we need to > do report support for the option, otherwise GDB falls back to use Seems like you are missing "is to" before "report". Otherwise LGTM. Simon