From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 65E9A3858409 for ; Sat, 16 Dec 2023 09:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 65E9A3858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 65E9A3858409 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702720182; cv=none; b=snFJOEjdAuxx6Do17qwLjDIx14MqO3FaYnagFpq9zUfnXCuCVZ0Hp9oiTd1Vs2L8FRF3QuD7W+7xnRarytqEIaBmbNfNYeFxq2owcafM7lLIH3nEMtsH2Bk0DZYRTOJlCbTAavF1WIioIRQ96x/7GwdvVsx+PPthfGZv3USWa4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702720182; c=relaxed/simple; bh=v/5OSQzDr8O5cAW/lP3aeXrHdbJYJJxucD9umUMaxqE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=hDMpaZ5oSQjN2mHVybP+esZJimsS5M178MfG0jgjGBigzTcwenz5bXSDWq3yqyRa2BGGWG/d3UsfU1/Va4zDcr4KLqdXU/xbceJHJ5peAdJVfGRERegLoEA+bMpMOhIDxIbs31ztOiApcMCZ3cQQgSl41d554hy7pDmgiZIj19E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 54F251FB42; Sat, 16 Dec 2023 09:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702720179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rxz+Z9Wr3DvUx+FtqVbPKPcUdoUm73oV4CSqa3bq49c=; b=UBp7raRUIPYvpjnQ0hgMPnxPU5SdqYAUYdJvbpo0oqaBVoSZgfZNzzW2IKq7A0Ca+nWKCh JUrvzveEflAI5PVqd2RvOii605KLOtJvU9FpUdOxtQyMsWhKoPYQGwHpgHld7b4l8xw2Ju LOnpQhyUkj1TIeaO5V7Of4RvYLx617Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702720179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rxz+Z9Wr3DvUx+FtqVbPKPcUdoUm73oV4CSqa3bq49c=; b=0yb6OLa6qSqYnXnDiYccibBKtiuCGlPsezhpXpApl+qYiYtwyg9rg+Q1iQ2+tWvJbr7Z0n 6K136m7fGz8/NeBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702720179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rxz+Z9Wr3DvUx+FtqVbPKPcUdoUm73oV4CSqa3bq49c=; b=UBp7raRUIPYvpjnQ0hgMPnxPU5SdqYAUYdJvbpo0oqaBVoSZgfZNzzW2IKq7A0Ca+nWKCh JUrvzveEflAI5PVqd2RvOii605KLOtJvU9FpUdOxtQyMsWhKoPYQGwHpgHld7b4l8xw2Ju LOnpQhyUkj1TIeaO5V7Of4RvYLx617Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702720179; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rxz+Z9Wr3DvUx+FtqVbPKPcUdoUm73oV4CSqa3bq49c=; b=0yb6OLa6qSqYnXnDiYccibBKtiuCGlPsezhpXpApl+qYiYtwyg9rg+Q1iQ2+tWvJbr7Z0n 6K136m7fGz8/NeBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3B76E136CF; Sat, 16 Dec 2023 09:49:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id EaDPDLNyfWWCbgAAD6G6ig (envelope-from ); Sat, 16 Dec 2023 09:49:39 +0000 Message-ID: <32ce8d21-fe2c-469d-b4d9-2b59a6c3890d@suse.de> Date: Sat, 16 Dec 2023 10:50:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] [gdb/tui] Add set tui border-kind acs-or-space/acs-or-ascii Content-Language: en-US To: Tom Tromey , Tom de Vries via Gdb-patches References: <20230419133743.3288-1-tdevries@suse.de> <87wmtf5k1i.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87wmtf5k1i.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: * X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=UBp7raRU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=0yb6OLa6 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.58 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.08)[88.06%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-0.999]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -4.58 X-Rspamd-Queue-Id: 54F251FB42 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/15/23 20:43, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries via Gdb-patches writes: > > I don't recall if we discussed or finished discussing this... > > Tom> The gdb TUI testsuite uses a custom ansi terminal emulator (tuiterm.exp) in > Tom> order to be able to inspect the state of the terminal, and consequently runs > Tom> all test-cases using TERM=ansi. > > Tom> Once in a while I manually replay a test-case on an actual terminal emulator, > Tom> using TERM=ansi to make sure I trigger the same behaviour, and run into funny > Tom> looking borders, like this: > Tom> ... > Tom> ÚÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄ¿ > Tom> ³ ³ > Tom> ³ [ No Source Available ] ³ > Tom> ³ ³ > Tom> ÀÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÄÙ > Tom> ... > Tom> This is PR tui/30370. > > IIUC, you are not using an actual ANSI terminal, but some other thing, > and then setting TERM=ansi? > Yes (and some other thing meaning xterm, gnome-terminal or konsole). > I think in this case you should just expect that things will go wrong. > TERM has to reflect the capabilities of the actual terminal. I tend to > think gdb shouldn't try to work around this kind of thing, if a user > does this it will probably affect any terminal-aware program. Agreed. FWIW, my meta concern here was difference in behaviour between test-cases run in the testsuite, and replaying those scenarios in an xterm. I think this concern is better addressed by the ansi-for-tui proposal ( https://sourceware.org/pipermail/gdb-patches/2023-May/199761.html ). Thanks, - Tom