From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 9BF1C3858D32 for ; Mon, 12 Feb 2024 15:15:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9BF1C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9BF1C3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707750946; cv=none; b=NOk00sht6VCvAvzEzZeBMXVE1kI+GRb1TO0iQo6OTJXHxXUUkoY6BYXrMsDlXoBOFZdhpcOxWAgPvWe+aeTWianaxAhdaIzUOhI8TLrIwy42kKrCknOa3tDouWXnFh/ZHmbfOiww7jT9G0c4KFAZutkbCxreUi/oJnF4iQOiz/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707750946; c=relaxed/simple; bh=Mmtu6Xu3I6ZhcBY896zgNKkQCnhAD6oT90CYMabbeZc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=fHU9tK5yYdVoAlpjB/yZTiYusYl0aJAF8gJk+1dQfYnJFw7fB3mRGv0S6X2mlOCD5RG9kiMux6Hsy6/A26nDYqF/0RWpKvxR8yA4hIF8I0h08GloUzozcaFpD4U4qs1Iln4e/x180lvfzRXTuvVnahaUfCNzF4Xbe1TUcLyR3i0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 919691F787; Mon, 12 Feb 2024 15:15:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707750943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ps4cp0VbCcJRzdxHNpHTEtRfBQUe2cOcij2st0l5zg0=; b=rtRw4l1q4x2N65VV2B3vaWYMjhR0PUlLZcsaJkF35t0jITvb+cH2ETf0FVFhYDYfK4E8ib Pzh+b1iD6nyWezdjZ+TvCt/eUMg1ciyBKSyLcK/f90zhIw0naVc1H3uXuMMJ7EnYtL0UtL 45UNlPllt7pHjQkg8WNGT1K6fMm3qYc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707750943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ps4cp0VbCcJRzdxHNpHTEtRfBQUe2cOcij2st0l5zg0=; b=+LfoJAo9ecuSlR0P+C0SZH30+INIqCOOvQaS6h9EOoUHOc00KdBaB0cRAH9ml8MRmIx1tr /v6lj6p1WIJzDwDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707750943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ps4cp0VbCcJRzdxHNpHTEtRfBQUe2cOcij2st0l5zg0=; b=rtRw4l1q4x2N65VV2B3vaWYMjhR0PUlLZcsaJkF35t0jITvb+cH2ETf0FVFhYDYfK4E8ib Pzh+b1iD6nyWezdjZ+TvCt/eUMg1ciyBKSyLcK/f90zhIw0naVc1H3uXuMMJ7EnYtL0UtL 45UNlPllt7pHjQkg8WNGT1K6fMm3qYc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707750943; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ps4cp0VbCcJRzdxHNpHTEtRfBQUe2cOcij2st0l5zg0=; b=+LfoJAo9ecuSlR0P+C0SZH30+INIqCOOvQaS6h9EOoUHOc00KdBaB0cRAH9ml8MRmIx1tr /v6lj6p1WIJzDwDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7ADF213985; Mon, 12 Feb 2024 15:15:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iBe4HB82ymVzYAAAD6G6ig (envelope-from ); Mon, 12 Feb 2024 15:15:43 +0000 Message-ID: <32efe6fd-f4c7-4d04-ae8d-43b3ce035d4a@suse.de> Date: Mon, 12 Feb 2024 16:15:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 2/3] [gdb/dap] Catch and log exceptions in dap threads Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240207090224.27521-1-tdevries@suse.de> <20240207090224.27521-3-tdevries@suse.de> <87a5occlwb.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87a5occlwb.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rtRw4l1q; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+LfoJAo9 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-6.33 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.33)[90.32%]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_HI(-3.50)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -6.33 X-Rspamd-Queue-Id: 919691F787 X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/7/24 16:52, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Thanks for the patch. > > Tom> - the DAP thread samples the gdb_stderr value, and uses it a bit later to > Tom> print to > Tom> - the gdb main thread changes the gdb_stderr value forth and back, > Tom> using a temporary value for string capture purposes > Thanks for the review. > I think the first bullet point here is incomplete. > AFAICT, it's not, but ... not a native speaker. Should try to I reformulate? Thanks, - Tom > Tom> + # Catch any exception, and log it. If we let it escape here, it > Tom> + # it'll be printed in gdb_stderr, which is not safe to access from > > Remove the "it" at the end of the first line here. > > Approved-By: Tom Tromey > > Tom