From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 4E6DF3858D32 for ; Mon, 16 Oct 2023 11:40:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E6DF3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4E6DF3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697456423; cv=none; b=u//+Fk8ky2O+7SPC/7Fos1YOSieytYRWLaccULAVXy3HA0vqNbgP8wGgFMQQBVY5ODcudqhwxpIUtrgVyngPes10mIm4qLktew6rFqZnOlGpCyJOwq0QF/kNXoRn7PWmxHPmN4nsCoL/VXbAmLghD6bqhcBZg/gRyz8nMbeDv1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697456423; c=relaxed/simple; bh=96jkZeaMsoBPrgScuiZwX5UwovQtws5ussRiA7tJ4GU=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=ukjZd3h1MJ3zUz16DZ1yIpCB7LpbC7MBvGwX2JTFAJszEIAwwxL02EjUjUbdnzLoPJSWNd9o5wHFzmHhHAfofyJAHK9h1BwhsBixi9AsrTF2OeSSaqfVtcldYNWsYFa20uqNe+GBRvnZZewUkzMg+btkVpPT7LYTCotQu4w94vQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0902821C4D for ; Mon, 16 Oct 2023 11:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1697456421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=etRvHSV3JaSmvTLEAWn+uPJfnRQjidlplR9L5a9ZjUM=; b=fviKSQ/Ne5DC29rIUgQWD467ArOAROL5thwNYinGdO26LC76igAOkuMoGizK0pSC/e7iVS I2VUOz8GhpQD1oKoE9D2E/Vfa7YCoN4g0kMj9g34KScLIR5TBjG9UqBqjb84ADDh1gamgq F6OXQwhFYJqhn2g08VCZdgaOLLhiLiU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1697456421; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=etRvHSV3JaSmvTLEAWn+uPJfnRQjidlplR9L5a9ZjUM=; b=bRpD4FK6FFGXTxbo483ZOUi3PoqmCy7g4ghl/Ce8iuhxWT1qzSbvl4BxL6WLTQUL4+ITOA X+ASJL0zMknIFYDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC7F1138EF for ; Mon, 16 Oct 2023 11:40:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6De7OCQhLWXYfgAAMHmgww (envelope-from ) for ; Mon, 16 Oct 2023 11:40:20 +0000 Message-ID: <33027d37-1c5e-4007-b189-2ee372327fcd@suse.de> Date: Mon, 16 Oct 2023 13:40:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PING][PATCH 00/13] [gdb/symtab, cc-with-dwz] Fix gdb.cp/breakpoint-locs.exp Content-Language: en-US To: gdb-patches@sourceware.org References: <20231002125051.29911-1-tdevries@suse.de> From: Tom de Vries In-Reply-To: <20231002125051.29911-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: 0.85 X-Spamd-Result: default: False [0.85 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.98)[99.90%]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_SPAM_LONG(3.00)[1.000]; NEURAL_SPAM_SHORT(0.92)[0.461]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/2/23 14:50, Tom de Vries via Gdb-patches wrote: > [ Submitted an earlier RFC version at > https://sourceware.org/pipermail/gdb-patches/2023-September/202443.html. ] > > When running test-case gdb.cp/breakpoint-locs.exp with target board > cc-with-dwz, we occasionally run into: > ... > FAIL: gdb.cp/breakpoint-locs.exp: break N1::C1::baz > ... > due to the breakpoint having one instead of two locations. > > This is PR symtab/30728. This series fixes it. > > The fix is dependent on the fix for PR symtab/30846, which is about incorrect > parent entries in the cooked index, due to inter-cu (intra-shard and > inter-shard) references. > > The series consists of three parts: > - patches that fix PR symtab/30846. > - patches that add two optimizations to the fix for PR symtab/30846 > (one preparation patch, and two optimization patches), > - the last patch, that fixes PR symtab/30728. > > The fix for PR symtab/30728 consists of adding entries to the cooked index for > DW_TAG_inlined_subroutine DIEs, with correct parent entries. > > Tested on x86_64-linux, with target boards unix, cc-with-dwz and > cc-with-dwz-m. > > I've split out the two added test-cases into separate patches. Unfortunately > the patch "[gdb/symtab] Resolve deferred entries, inter-shard case" is still > somewhat large due to moving code about. > Ping. Thanks, - Tom > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30728 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30846 > > Tom de Vries (13): > [gdb/symtab] Factor out m_die_range_map usage > [gdb/symtab] Check effect in parent_map::set_parent > [gdb/symtab] Handle nullptr parent in parent_map::set_parent > [gdb/symtab] Add parent_map::dump > [gdb/symtab] Factor out m_deferred_entries usage > [gdb/symtab] Add debug_handle_deferred_entries > [gdb/symtab] Resolve deferred entries, inter-shard case > [gdb/testsuite] Add gdb.dwarf2/forward-spec-inter-cu.exp > [gdb/symtab] Keep track of processed DIEs in shard > [gdb/symtab] Resolve deferred entries, intra-shard case > [gdb/symtab] Don't defer backward refs, inter-cu intra-shard case > [gdb/testsuite] Add gdb.dwarf2/backward-spec-inter-cu.exp > [gdb/symtab] Add DW_TAG_inlined_subroutine entries in the cooked index > for c++ > > gdb/addrmap.c | 19 +- > gdb/addrmap.h | 7 +- > gdb/dwarf2/cooked-index.c | 141 ++++++++++++++ > gdb/dwarf2/cooked-index.h | 145 +++++++++++++- > gdb/dwarf2/read.c | 178 +++++++++++++----- > .../gdb.dwarf2/backward-spec-inter-cu.exp | 111 +++++++++++ > .../gdb.dwarf2/forward-spec-inter-cu.exp | 107 +++++++++++ > 7 files changed, 657 insertions(+), 51 deletions(-) > create mode 100644 gdb/testsuite/gdb.dwarf2/backward-spec-inter-cu.exp > create mode 100644 gdb/testsuite/gdb.dwarf2/forward-spec-inter-cu.exp > > > base-commit: 6a6117ab0ffe18ea984abca84869eae799c1b346