From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id E3E763857C49 for ; Thu, 7 Apr 2022 19:23:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3E763857C49 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id 123-20020a1c1981000000b0038b3616a71aso4290184wmz.4 for ; Thu, 07 Apr 2022 12:23:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z8dUYMli8qRGplVg9GAtjFCMq1BMO1pcDEjgGpCexw4=; b=V3oCFa/WUWpdPnX52iIfU2nSxa6smbbQfNud0afrHGwydBeinXFBsWiMGlPY1FMRNQ K7LIImjLBB3R1tFPfpnc89icGhni62hlkHeDk3EPGKyQXFZn/zCog7mYjNDs+ux33PW7 Dlf7j4bvQwnZxPAxe+Uxj1EEO48m4tyQGr7564d3Wktg2IC4vc6EBQMPltwV6fzRxfog +JuCkVljTrSWYQTLCsWA8z6skPYGYbpOOYJ3zAKhSKO/hHqznVrfyXYPNXvD+r8fjvyJ HBCFWDvpsuiJiCRnpTEyl8QsYDVGu2zovr6LmkZ1CkhMZEHCaAd7SKvB+1K8AWxOczfS U5YQ== X-Gm-Message-State: AOAM530WH3JIuEg84m1e+lni1295Assj2pxwyxAC4ilxjxY7Nq5lkLpy M2e5E3w/kw9pGaDa1QvBBskf49+PIr7u1w== X-Google-Smtp-Source: ABdhPJxKVaM2670+0GrA3Bap1nHMp69WY1OnaAaqJtSLm8HbSQ7NbJMc17Jes2eOjFSrEWnuKR9vEQ== X-Received: by 2002:a7b:c310:0:b0:38c:f07a:e10d with SMTP id k16-20020a7bc310000000b0038cf07ae10dmr13859891wmj.110.1649359379742; Thu, 07 Apr 2022 12:22:59 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m65-20020a1c2644000000b0038e9c4c9118sm1162210wmm.32.2022.04.07.12.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 12:22:58 -0700 (PDT) Message-ID: <330c3629-46ec-7b5b-3892-26362f5ada5b@palves.net> Date: Thu, 7 Apr 2022 20:22:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: GDB 12.0.90 available for testing Content-Language: en-US To: Eli Zaretskii , aburgess@redhat.com Cc: ssbssa@yahoo.de, gdb-patches@sourceware.org, brobecker@adacore.com References: <83ilrzap07.fsf@gnu.org> <83mth67i8m.fsf@gnu.org> <72ad3448-0ff0-f36c-d1f3-cc194c0503b8@palves.net> <83ee2i72vl.fsf@gnu.org> <87sfqx864d.fsf@redhat.com> <83fsmx59wi.fsf@gnu.org> <83ee2h59m2.fsf@gnu.org> <87pmm096dc.fsf@redhat.com> <83zgl44w1m.fsf@gnu.org> <1379565857.1750775.1648990951974@mail.yahoo.com> <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org> <83wng1b161.fsf@gnu.org> From: Pedro Alves In-Reply-To: <83wng1b161.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 19:23:02 -0000 On 2022-04-07 12:09, Eli Zaretskii wrote: > --- gdb/event-top.c~0 2022-03-20 06:59:56.000000000 +0200 > +++ gdb/event-top.c 2022-04-01 14:06:22.164500000 +0300 > @@ -821,19 +821,6 @@ gdb_readline_no_editing_callback (gdb_cl > FILE *stream = ui->instream != nullptr ? ui->instream : ui->stdin_stream; > gdb_assert (stream != nullptr); > > - /* Unbuffer the input stream, so that, later on, the calls to fgetc > - fetch only one char at the time from the stream. The fgetc's will > - get up to the first newline, but there may be more chars in the > - stream after '\n'. If we buffer the input and fgetc drains the > - stream, getting stuff beyond the newline as well, a select, done > - afterwards will not trigger. > - > - This unbuffering was, at one point, not applied if the input stream > - was a tty, however, the buffering can cause problems, even for a tty, > - in some cases. Please ensure that any changes in this area run the MI > - tests with the FORCE_SEPARATE_MI_TTY=1 flag being passed. */ Don't we want to preserve this comment? > - setbuf (stream, NULL); > -