From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2132.outbound.protection.outlook.com [40.107.220.132]) by sourceware.org (Postfix) with ESMTPS id AA45D3858431 for ; Thu, 4 Apr 2024 07:40:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA45D3858431 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA45D3858431 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.220.132 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712216457; cv=pass; b=Eqci7M+VUPf/VxTLb4Zw9IYD2W/xpNEkTPwTZVO1UE2Rbb0nYXyc3QLEeP/UOLCS9S+7JWbAIMP7lNKf8El/dTVKs1WbaD4vidYRWS9b+XC4hdKUCuxm/zRO6pkT3/bpk9jZwmb4T5aPGyhM2x8Q07Kk/eFNMed82egYcbPwH5c= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712216457; c=relaxed/simple; bh=mryITrQBVLUtyBziwu2z4HAwHVUQnI4seMh52MefHuI=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=FdI3bI5K+TwvT8cI0867I2LJJuHmzAmhxXkGn27LWPG62V/NTScqHEENHPcTmpkrstJ+MaK0N+yUEFzG+0fPaYksFTYujYsRYwQtmGmOGlJmRnUMUsSXuNhDcddkRHBT6ZMKoVU6J72tnzDC4Zcj9rczyjkXojiZh8v9liEs8lw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XkpK4udY1TV3SfPEuxVmuw6rreH45GRtSAqnvlmNvA4LCXzolsA7S7GwvlIC9A/eDfFRFg8rsWe2Ul6BhfYn4eumOs43lh0fcCPOfKiRLw0eeuCNrI/4ug0A4cD5XVFyg5HG1zAx2x+KJeuw17RUqQpNgRJvdBNXi0gQIPH7ebC8TxImQAMWzAWGSQd23HBGcvdcY0C/gaQsgp2KWoNrwnTBZYgKLQDtCHtd/CJ0HO9JLVL7Yk2qH3sbkzKdzTnF138PRZ7m0BJAR4OzttufmmDLQoxnBXH2EisNqVKDhwbWVtm1JfI7enZHdFUy57oHAjX9tz1P4CfV10A8HJYhQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OCfuyzxOpMyF8Sit2SEh0g0JMRVAZwN+d65q5jl8/mI=; b=niFIgznUEIlSDbkZ/2kTubLo42xvy2caBsGKckssRqbiy7mCq846lC2OFzPLBkBHsZEzWoSGkQwgqz8aiuHFbRdJmDl9Gf+dM9bgzrDRBjs6YeFZK7J4w0bG2zLVASvgY3GD1iXdgRBrmgBu+XTs7s9wsfbg0NWUqlM/8UB2lmkWgZIaX3qxtX9GmhD3FnjJahzaBK0ZfJX/JtlUkf4wPfLyoup0/9jyvYnveWVlSLUoxbgIZD379hNwyu0AP7C+tXg7gb5EA+99OKqkVpmCsaEGXpHqpd6SOJiETK71v/s/2qvKj7ZGokYaJJAg2VObRkPBSroB17Ug4XqS+trw7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OCfuyzxOpMyF8Sit2SEh0g0JMRVAZwN+d65q5jl8/mI=; b=4ySPhCmd6edoQC7tyMzgln0YlZT5mJONI4uz7sEY05DUEhu+F9xZBnroFP6m3WbuUCrr95ibSakquBqzmLTObwN6y5zrV0LXOtnrkTmEaY8nw6Vk2EP/Bjlxo6cZ213RWPIyUval/XCE8xnY5aEeSCuQxrSoYqlzbJqF/csm0AA= Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by LV3PR12MB9233.namprd12.prod.outlook.com (2603:10b6:408:194::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 07:40:51 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::f98e:8d91:f485:89f9]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::f98e:8d91:f485:89f9%3]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 07:40:50 +0000 Message-ID: <331746c9-ff55-4ae2-9677-b555275ed8b5@amd.com> Date: Thu, 4 Apr 2024 08:40:45 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/compile: Use std::filesystem::remove_all in cleanup To: Andrew Pinski , Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org, lsix@lancelotsix.com References: <20240303164756.870514-1-lancelot.six@amd.com> <8734t0sn8d.fsf@tromey.com> <6689da3c-9229-4338-9cad-b3bbeb1bbecf@amd.com> <38c53217-76b5-4ec4-8235-3eb8ca021d2c@suse.de> Content-Language: en-US From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b7::17) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|LV3PR12MB9233:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fvolrx7G7ZOF4pbIWV+5E2/M9fMUGzPJxjzan22mknoRKN/6rLMzXsLV3C1hZ/KluqiEYl8ceZXBB0VcjcdhbRgjwConUofZLIQ6YwCROltQRQZI3HQHprXpFIrRQhscGOu3Yw/YYUKT7yslBkYNe0Z7Ws67NnnlA6gJFb2W0PWK+FeHLAvGJBzmM/MqDKOUKylPsFMHg0QJ3SCEh1lELN9J5oSZcb3EN8erYpBrZWNHNn6D6PDGlK7h07FZQ012chCxw4HPeCkxmFc/NKSp/n0+PMVIbNVXHEZaKyV4Uw/a4DDT9rgBfodtfVVCnrFtr8MrQyhjn1+tIXWuh//PkXndSlJJgrGTgWgpzqYW+CcIe+idchSpFKLLEyTg9Q4eNqSwFOO/lTVRSnujhuom7W5wXDNalE8/g7tvjKoSdfXD0Ek6QoWNaZQUx94dEdMs8crqMp/zb1gM22W0udMb+xBB1ODRjS2uP3xJRv5BPAMp6l83v6s3uPnSye2TICMWKnCMAqLI26ibpIJKD4x46n2kw+r4Bsj2kO3cs5a8CpO+aRD8wuC4zbEEw53HLmq/tVpbWFsrVHKrtDGYWB64Rtt2gZBa0fSlTjPn0+p8XSYBxY3fdWTUHqyDpUbJ4gzrnmTlP9CtUnbiZl6glK6rIo2tQ4fA+5j2RfwW4JzqE/I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3BLa004TmtpSmtIcmJiUFRrSndReGJDRkkxOEdlMnRWK3RUbFZZdkZqNngz?= =?utf-8?B?ZkdTUU1jcFhaR0pLZmF4ZHFlU1BuN3lPcjFTVTBNbmZOUjNCWnZ2dnBsTFhq?= =?utf-8?B?c1hmbVZzL2ptVEhUZVBGa0Y1ZzJ0dVE5Vjh3cC9GSUVwNVgzek9vSHAyTnZ5?= =?utf-8?B?QkJNdG5Ia3ZoOGdHUVFuQWgzdDk4bUNFVlJneUFZZUN4ZHFocHJkVy9FVDFs?= =?utf-8?B?cjNmWjIyY1grUmFOdjZvRUtEeWYvRDRnS1pXV1ZXU05MWFJwUUdZbmoybkFL?= =?utf-8?B?SXpwcTExbFpPVTlkYTl6dXVzRjNRZDdOOUNwaERDSDVSbi9JWnM4RDZlS29S?= =?utf-8?B?cG04cjBUaXJEcVlLUGJhSWIzZEVaUXA2VmJ6NWxPRUlXakw5bnc0ak1sd3RV?= =?utf-8?B?a1huS2lodEFEZ1VjbUU5MGlKdzlVaDVkeUZSQVN4Ym5XQUx5aU5uRVRyMC9K?= =?utf-8?B?b2ROT3JmSGUxcVBvc0IzZjdpSFFyMExVdnhNcFVjSGxpYW9ZQ1dhR0twNXRB?= =?utf-8?B?YUhMdzJKVzF2dG1uK2x5Y2NuaVFPUUtNZjM5MFpNNFpkeStUc0VsdExyM1Bu?= =?utf-8?B?V1FzeXRyczdncXltdEdRMVk4d1lDUTVpSnhOSktDVTdKWWtHRFhCR1djc2Vw?= =?utf-8?B?VzlOVTU1cXZqeHhlbGxoSlg1dEFFU21lQS9zTFFiVmRYTk1UN291ZzIwU3Qr?= =?utf-8?B?N1NMcmdsQmFUSGxVaWtkQ2VRc2V5ak5kYU9neWd2bTVPRHYrYVBBWGFBNHlU?= =?utf-8?B?cXNycjNRcmxBMUZEY2tNOVE4cWU2a0pFWEh4dVNDSk9yWFdTWTJ6akRqNmFB?= =?utf-8?B?akJ2em54UEFRSm1TU1R6YVhmTTRkcjBXTFFyQ0ZrUVRlRFlCNEVJZnZVS1lz?= =?utf-8?B?NENUamo2cDFpeWhJdW8wZURRbjRLNlRoMnppUEFhWG9YRnlrRjdSOEh0cnho?= =?utf-8?B?WjIwVnZCUkpBQkVJSDZldmNNQ0o2KzF0cmRLTGxEcmxONU1WRXNwTDNrc3dq?= =?utf-8?B?ZEFVMHU1d0d2SFNUVjIwbldXSTBlcE1LRlpBdDl2LzJIWTNSM0E0M0phazMv?= =?utf-8?B?K1g0S0ZDd2hSMDY4V0pFL3RCUnRLZXI4amhERERQelZLSFNncDZFNGt0L2pz?= =?utf-8?B?Y09EYkRhcnFjVlF4aXJ1bHZDRXNQVnJMZHZQVDdlVUYrZ1dPeTRaWkYrMXU5?= =?utf-8?B?RGwvSGVDaisxOG5TNEJUUkdSNnRvSzhaK05mMFNHbVRUcjNIaUptZEd5Z0or?= =?utf-8?B?eHdYTFlSNk9JTFRYVllPaE1uZlJrdXJFRUVrT2J6NG55VVZFQkhjdFdPY1dF?= =?utf-8?B?WnVoeDh2ZEpEVm56SEsrenNhTVNQQ3pGeEI2cHczSTlvNDVkZGFJYlRpcno2?= =?utf-8?B?NEtOQktOTkFRRWtoT3dZeEN3TU9JVmMwK2xyQ1RqYnkxWkFOU0Y0SFdGeTgx?= =?utf-8?B?blZjUGVCd0hKNFlUb0phemdLY0xWN1BNODlDSVF4aUNNaFlLaTYvSEVvZ3ZS?= =?utf-8?B?MCszYUdBZVlKNnRIdTRyaWljZHdGN3BJY2FFSWYvNXJMbzZldTNpaVNLb3Y1?= =?utf-8?B?Y21IQUFpdW4zRnZIRFpmcVVmWDdqZE5VZHFRQnVVVi9LRHJIck5vWXRoYlRj?= =?utf-8?B?ZURKanF4cmc2TWZva3ZWb3M4bVowUlpIMkt1bVQ1LzNNazJWVmpPTUJJdG5U?= =?utf-8?B?MEFFZXEwNTdGMGdwTVNzYndHOXduUTNxWE9CQ0FhVFY4WDFJenVQOCszQTRm?= =?utf-8?B?Z3VmYlA4c1pqK0drbHFleFczYTd4dnBoZHIrUGs3ZmxBMzRIRzNSK1JSTUhK?= =?utf-8?B?eXAzOGk4cTU3NlYxL056ZVpwVmFlbmVCaWg0cElEc0VOdzA1bkVLdmttM1JJ?= =?utf-8?B?Y3dPais0b0MzUEh1aCtaZmpUZlpGekgvejBUbjJsNXozazBnUEtTdG5kWE9T?= =?utf-8?B?VktQTTBUVmFZRHlOaTAwVnp1MTcydmZHMjBZbFQzcE4wUlhnbkNLM3hPclRs?= =?utf-8?B?MmZVamNxVk9wSUxENVVqdlZYY2IyOUJOM21qd2VUVExQYVY2VzN3V2RsVVpB?= =?utf-8?B?NGZJY25IS29ZdERPM3ZDRzNwNmF4WnVYbEVLTDZHOS81R0g4Y0JPNlNHTmRs?= =?utf-8?Q?bT3jd2TDg4ohBsVL6DiMiuzY8?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 135ab222-82af-401a-fb46-08dc547a8ca3 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 07:40:50.4537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DoYKSoC9TNVR3+o5WRiN0rQCsZ/c2a4Zfv5L04gmd3bgjWz6q3qlZO6KCDdxLdlJEjvMdA42iTqPLyfcADb+Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9233 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> I wonder if there is a case for conditionally enabling this. That would >> ensure that the work is not lost, as well as used when using gcc >=8. > > Let me add even though support was added for GCC 8, the functions are > in included in libstdc++fs.a rather than the standard > libstdc++.so/libstdc++.a. > It was added to libstdc++ in GCC 9. So if you add this conditionally, > you either need to do a feature test that does a link too or have one > that adds libstdc++fs.a if not found in the standard library. > > Thanks, > Andrew > Thanks for the input. We did discuss briefly using "-libstdc++fs" on IRC, thanks for the precision regarding where it is required. As gcc-7.5 seems to still be used to build gdb, it looks like we will stay away from std::filesystem for now. Thanks, Lancelot.