From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 1AAC63858C52 for ; Thu, 28 Sep 2023 18:23:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1AAC63858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 379E71F896; Thu, 28 Sep 2023 18:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695925425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6gaYx+TzXvcZxsjjXdzbujld1kY1m6sv566KvKrs9kc=; b=CewBnTfLJdvNwX2UT5tz4UrtjFl/U0OQJ9ykt8D/CMeSf8TnI9ZcRbU2d6/+QhnQLcET94 EyJkhTge+16crAukz/WJcxo6te1SkltUhtfHpKhhqYQ5T76XHRwFIHnx/m7v5qmPhQPFBH jUsiOqXTp1mno3t9c8MkfjfICh8GcuU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695925425; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6gaYx+TzXvcZxsjjXdzbujld1kY1m6sv566KvKrs9kc=; b=KtEqfvD488BBSAZbZTILmAATORZJcylL9lfZCe4PEqjiMjZpl6kloRQSQlb94tyQvrPEeI nXqS7N3Dzq4u81AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21E7F138E9; Thu, 28 Sep 2023 18:23:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id L7IUB7HEFWVkfgAAMHmgww (envelope-from ); Thu, 28 Sep 2023 18:23:45 +0000 Message-ID: <331a1695-74a8-411d-84c0-7de424b7b59f@suse.de> Date: Thu, 28 Sep 2023 20:23:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/tui] Only handle code sections in tui_find_backward_disassembly_start_address Content-Language: en-US To: Kevin Buettner , Tom de Vries via Gdb-patches References: <20230905150339.6452-1-tdevries@suse.de> <20230905150339.6452-2-tdevries@suse.de> <20230927091536.19f732ad@f37-zws-nv> From: Tom de Vries In-Reply-To: <20230927091536.19f732ad@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/27/23 18:15, Kevin Buettner wrote: > On Tue, 5 Sep 2023 17:03:39 +0200 > Tom de Vries via Gdb-patches wrote: > >> Fix this this by limiting tui_find_backward_disassembly_start_address to >> SEC_CODE sections. > > What will happen when a user attempts to use the TUI to look at / debug > dynamically generated code? > Hi, and thanks for the review(s). Hm, I don't know, good question. Maybe it will be possible to detect these cases and expand the search, and by default do a more narrow search. I'm not familiar with the dynamically generated code scenarios and support in gdb, so I'm dropping this for now. Thanks, - Tom