From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65064 invoked by alias); 11 Jun 2018 18:02:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65010 invoked by uid 89); 11 Jun 2018 18:02:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=yao, Yao, 2017-10, 201710 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Jun 2018 18:02:46 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4AD71402178A; Mon, 11 Jun 2018 18:02:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C992863F4F; Mon, 11 Jun 2018 18:02:44 +0000 (UTC) Subject: Re: [PATCH 3/4] gdb: Run INF_EXEC_COMPLETE handler for additional cases To: Andrew Burgess , gdb-patches@sourceware.org References: <59b1b9214bf0db884bf2eefcdacbf4e148137e57.1527157948.git.andrew.burgess@embecosm.com> From: Pedro Alves Message-ID: <3326b6f6-fc6c-a777-0f74-2c0aaf3ba154@redhat.com> Date: Mon, 11 Jun 2018 18:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <59b1b9214bf0db884bf2eefcdacbf4e148137e57.1527157948.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00291.txt.bz2 On 05/24/2018 11:50 AM, Andrew Burgess wrote: > When making an inferior call, and non-stop mode is off, then, once the > inferior call is complete all threads will be stopped, and we should > run the INF_EXEC_COMPLETE handler. This will result in a call to > 'target_async(0)' to remove the event handlers for the target. > > This was discussed by Yao Qi in this mailing list thread: > > https://sourceware.org/ml/gdb/2017-10/msg00032.html > > Without this then the target event handlers are left in place even > when the target is stopped, which is different to what happens during > a standard stop proceedure (for example when one thread hits a > breakpoint). > > gdb/ChangeLog: > > PR gdb/22882 > * infrun.c (fetch_inferior_event): If GDB is not proceeding then > run INF_EXEC_COMPLETE handler, even when not calling normal_stop. > Move should_notify_stop local into more inner scope. OK. Thanks, Pedro Alves