From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 14CFB3858D33 for ; Wed, 1 Feb 2023 20:54:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14CFB3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A97641E112; Wed, 1 Feb 2023 15:54:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675284872; bh=BeR/PJc8bnVsxuL8qzXOLlwgblhvobxTplDIH2th5dg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=W+ymTG8jZJNC60LtEXwMBQlVypZ3lDwNArBVfkG1fGkQlS5gUw+FzaepJ8gcXLkY8 0w4bR4lL4/qzx3I/+NnLSoCIuVbHS/NaFoovn/+dSJd9znV6y1dkVYTmzgzDmPJVN/ kJtrlN0zgT1w5P9qO1Ga2OwIVdHjOCudHg2x91QI= Message-ID: <3328631d-8723-3734-dd8a-ea1fa76fa2a7@simark.ca> Date: Wed, 1 Feb 2023 15:54:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] Simplify checks of cooked_index Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230201184509.3499301-1-tom@tromey.com> From: Simon Marchi In-Reply-To: <20230201184509.3499301-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/1/23 13:45, Tom Tromey wrote: > This changes the cooked_index_functions to avoid an extra null check > now that checked_static_cast allows a null argument. LGTM: Approved-By: Simon Marchi Simon