From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14229 invoked by alias); 19 Mar 2019 17:46:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14158 invoked by uid 89); 19 Mar 2019 17:46:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:514 X-HELO: mail-wr1-f53.google.com Received: from mail-wr1-f53.google.com (HELO mail-wr1-f53.google.com) (209.85.221.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 17:46:32 +0000 Received: by mail-wr1-f53.google.com with SMTP id g12so22193850wrm.5 for ; Tue, 19 Mar 2019 10:46:32 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s187sm5978647wms.7.2019.03.19.10.46.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Mar 2019 10:46:29 -0700 (PDT) Subject: Re: [RFC] Don't show "display"s twice in MI To: Tom Tromey References: <20190312190320.19645-1-tromey@adacore.com> <0a23b883-9c80-a9e2-1e3e-3aa8c0b0ce13@redhat.com> <87y35ix0pv.fsf@tromey.com> <3cf86a8c-3448-1826-61bc-dff0faaa0744@redhat.com> <87wol2h4iy.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <333a055c-1174-c5c0-f809-8fc89c991f2c@redhat.com> Date: Tue, 19 Mar 2019 17:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87wol2h4iy.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00411.txt.bz2 On 03/13/2019 09:02 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Maybe we could simply move the do_display call elsewhere? > > There are several spots that call print_stop_event, so instead of that, > I just added a way for the caller to suppress the displays. > > I also addressed your other comments and tried to tighten the test case > a bit. > > Let me know what you think. I think it looks good, thanks. Pedro Alves