From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id 5865B3858D20 for ; Tue, 11 Jul 2023 12:01:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5865B3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3fbc63c2e84so62006785e9.3 for ; Tue, 11 Jul 2023 05:01:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689076896; x=1691668896; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HNraQ6kDa1GVB9TIznAduiyb7wvXxTEe//JslQmjzXA=; b=EK92Tk8pG1QQ5czYH7KM+mdsI96Sr4qSiGARo434uJ66bUKSaHdD98aDaVBnZ4x5bY UvxK1UIbX5XxOg/HXFAh4UP9hoOhyuwRiqQiQDmiuN2wRQCRSGqIMaZIb8CtQ0GcLyif MYKXesrG2pK6nlx8J1cR4pBDB0eYqCFJ4+Ykkn+rZC7WTWt0CMrYgMsQSG1tAV3VO349 mhXSpOPG7YyWgOnbY6EAFeB9ZEaDhSENp2/0YxhGuk0jvzS9Sk5cJYhyY/0Sl+LFTc0h QIpP1MBBQ7jGN0PiTgWPBTXJRWfEGkJbK4uhaPqpqxHTEbF7MqP3zEa5b8lZQk37uYww U+EA== X-Gm-Message-State: ABy/qLa4R3dt7SR6v9Lda7sjkSyv92LaK4f/gcRfkhx9bgHAE6ByXJTF 8FCkFl90UxuflLCzD6AyjOnfjXm3qc4Kwg== X-Google-Smtp-Source: APBJJlFmI1dwPMOsPR2RBNLgotecSFVtLp7K0sSKulDMS74MHnj5oM1Mn9WQz/WquNIhPS6wiV+Ktg== X-Received: by 2002:a7b:c5d4:0:b0:3fa:9e61:19ed with SMTP id n20-20020a7bc5d4000000b003fa9e6119edmr14421536wmk.23.1689076895339; Tue, 11 Jul 2023 05:01:35 -0700 (PDT) Received: from ?IPV6:2001:8a0:f91d:bc00:6538:516e:5056:f36a? ([2001:8a0:f91d:bc00:6538:516e:5056:f36a]) by smtp.gmail.com with ESMTPSA id c25-20020a7bc859000000b003fc06169ab3sm9481190wml.20.2023.07.11.05.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 05:01:34 -0700 (PDT) Message-ID: <33456123-8fd6-67c5-18dc-293ead14bbed@palves.net> Date: Tue, 11 Jul 2023 13:01:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/6 v3] gdb/debuginfod: Support on-demand debuginfo downloading To: Aaron Merey , aburgess@redhat.com Cc: gdb-patches@sourceware.org References: <87351zls9p.fsf@redhat.com> <20230710210102.139114-1-amerey@redhat.com> Content-Language: en-US From: Pedro Alves In-Reply-To: <20230710210102.139114-1-amerey@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-07-10 22:01, Aaron Merey via Gdb-patches wrote: > +void > +dwarf2_gdb_index::expand_all_symtabs (struct objfile *objfile) > +{ > + try > + { > + dwarf2_base_index_functions::expand_all_symtabs (objfile); > + } > + catch (gdb_exception e) Write: catch (const gdb_exception &e) ... to avoid slicing. This catches QUIT exceptions as well. Did you mean gdb_exception_error instead? > + { > + if ((objfile->flags & OBJF_DOWNLOAD_DEFERRED) == 0) > + exception_print (gdb_stderr, e); > + else > + read_full_dwarf_from_debuginfod (objfile, this); > + } > +}