From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic307-54.consmr.mail.ir2.yahoo.com (sonic307-54.consmr.mail.ir2.yahoo.com [87.248.110.31]) by sourceware.org (Postfix) with ESMTPS id C57E03858D32 for ; Tue, 5 Dec 2023 17:57:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C57E03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C57E03858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=87.248.110.31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701799024; cv=none; b=uA3zj1IsHWjJF0mJ6vjhomqqlOnWk7vV50ZDraAX0gnID4lBiNmL2zdRcfMrCQFT8/eFI4Ckgmdzkl/TQIiGjVDIZvxm+hUTbq9RnVPwBerpdfw+KCSZYnJHMgWh5vEJIkVxhX70vmkotAY3nmSKqMnK2Dz5oykfFi7Gv7A9Ee8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701799024; c=relaxed/simple; bh=L2QstpQ17c5ZxN46b2PBW7w0PWK8y5sPPwsB8s6cVIg=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=twwP2x1GzHQDRd45hFmmpl6ykpTQeaWd3mZ28STnXLeotzZnf+w5TQjUWYO5Ci2rFteb83XB/bTe5EbfBZG9nCUvnBd8DGWy3MZXRdHcARGqYYZG9Yeb+H+ZitnqfG8yI3sU5L0Pdqm7HJa3xKwoq5+3J5JYRtyqS4XsozNR+hI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1701799021; bh=L2QstpQ17c5ZxN46b2PBW7w0PWK8y5sPPwsB8s6cVIg=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=qW7kkwIeewvSl+RJ1Yb6ZiRdNTcfYrHvwxQc4hFvSCCz/wuf9gQOqk14boVTyzDu+owsiAdrjBzyYFPOqwrFntmiM6xmCjfH20Vx6Om/ag16yrX/TVMYAj6AGhy5A54HOcFFdgs+VAgwgcnkC/L89Q19Z6xiW47XdSgxgUx933fjwcv4zpj2z17NU6jR2f4hczdbjYQW/jf0RSrRz+80m/6NnwnbSoyF/XEhLt2w3rl38yWTEmHdd9EflG3pFPpIllI9FfP3SUhSMdbtsKlFMuGI/8rRo4EpBB4vqZcpwEUDl+erNbNUL3MydFObeBFIWG0Etcq11WXZF3yy3/yBJA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1701799021; bh=GCRgiImszBkDKtMUh81xrs9G2qiPDrNNpVLgYOmo7Ao=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=bucFVkec+X2sB7m6DXObltxBVziJLr41Ug8wvldgORVeXhmBrPbtgB8aAWSu9otihudOglcNcXz7hvXcnwvqPCDm2kBtFLyAhAD3OeAjKg2I7DuH8pJcjZraS8zf4pGrq0qyjA3cFo6ko8uKIbeXQFk+jkH24SM5GyEkMScOab/RRpVg84On0zt+dzcxpliyFnIfrJUai8J3Sv5Yw8lTlwJtsaC6XFDaZtNr/TG8sfoBWunp1Xhe9v4Mh0H7mAXVLxp/xaDKQ8i0/A64NxB9jg3mSVSCgzT4dBLylc9uPAIp7+vOPBlibRM1GhBcRs3v5Mz9Q59wLAXzaFMnujGr6w== X-YMail-OSG: e9PNlRcVM1lwbL7yOmA5QQtHtiL4jFiJ3u_x8bivsAFG8SnXrxwul8x04.ZcD4Y orbfeRIVviz04YvaKtcIfQrjimS9uOu87J5wrEugk35yHhkCaMQnkOotGVzS2WPQlpWyqvEtDYjd KfuJehjv9St99jP2vKFCgJl8T_Keh66pWBRannDpI0J_bovBC544Hi0ypJs2geXjRbRNxqvP8bO7 v0qGVCTsrPUBW2xYMmN79ZwKzazu5Z0Sr4dyzxUL6hg0LgICzO5Yh23sf5qmsvlBA.x9ET5rJ6ek T49gnUnd8._HQNr6vhAjEKBg4SEaHyTqhQw91uzZ7FeKl5nrVWFEqsNpQ4Pu_gMkU3X9Ceqny1x6 fRXXmwVg8_eZo5iLEfNEIthIMb1SQ.DtnXWZ0KgwPgWUvwvZr41AFaq6j1J7ONCe9wKEcTFxYQlY U4Eu4PArcb3oflaaeEwCCLxj4Gkwvqx1ARG_ItaxyMD5bmmV3TWuxPKNLSU0HtwoCVQfLIb50kXx uVf45Ng_FNZv3Y2cijbRGbr5VX6fqfsgJ1M2udN_DReO0MiLCgg0huw_8Dr_dsu557SwIYN8FOla kLdzBKCOfpdQGaYuckNpRn4lBpGfTKXENKkYL_NwgAC27RQVXTvBZYzqsDokt1xzTAQmuCnQHGZF eA_5wkxaeR.yXS50XbxNTz9UpPXPDBWAYlhml1t5VEF2pd34TZl_.8Aw1payNUgPK5_zk6dJ_26s zO.xDdcjiv45eBr0K3y4UykuVjXTRVYgNO_PuMZ.Go846e74oOGRulfqYgROmhyQxIBwUSH.tdbI dR7WOQn177xJan17VanAhmeqY6eoPzsHt0fQM2e3Hxl3271Mkql75xFM04Q7ukQ.25cradse2w1z YID6uTNd2FnaLV_dVp6S6FNvrLvnvv45LlDuylwzrhy2O1Qqeqe3mFppjE_412MqVZpJY1e9sPBn sGW1aVNnbc3RKeb1XAbIUFzI04iBWUuzFypIai7JcS.kvyOhDn2k4adPau6IN8AFRuHeVNmvz53c 0PWNhDa1J8IVZIodGyM9vJUyq2DyotwhkbdQBE3Y3LK0TU5Tb4K_rt.mxm90UsXODOF9V_FJvT_i _WujFy5nKFpzIRzMHQTJmFll8s07Qr_D3En_OtgVAJQ58kTUIwnKTPt4CULjuQitFK7r2DkO41Nc ymOEB2utTOe2PnWPYTJHFSJGxoSCpfEeeGJt_NImP4hYAKhUxk0vCTHAIY6s7IYmDGpzYsBrvtn0 lXJ0cGjSh5f_HGMXvvIsvrZIZwrQJSwcbpNkZyNQ860FHUHnO8TbsUSVZt6LPJi.EQ5t8X2DfsxW reiean.WFePKr3A.W09peprvYATxOrYF0T8W6glCpcm6jV3Gso9As0fViO3ZY2j0jG8p.RncCPaC 5PDwm4TTBKO1t3OS8PN7sSTXGAtRVXDSxk2FVOpzA_z4AjmIHpsvfJ4KSnc2tqJiuXMpP2BV7JG5 Y1L753gItE_Ah_PVy6ZvMToAIqImHLj_cRNqqVkdKZOewkXOYPzCPUsDGrMs976tZ0q0ROcjQujE TEPkM0kRFLZLU9zGbmq2LICh5Eo4aTvMZpMydR9D3IrdQ7PRZ6Yf7VSVPd1JTYz.u6HS75pjFD_h .HG7y2fpgQSc5nOBWTjNtpl1CbXMu7jX_g6pmO8ScOztHy2f8gf5EspoXjkUFGjCZ35gB0SfJKZB xZk9exMab7jnmVXOsuOum.gncf3vfWcFY57iqPTu.aQgZYsN9Jf96WHMoI4ok76vzxrQ0xvqQbsb 0OTF7qri.T13U7eyZcp11NJWMaSRnGWuzrg4f_llsK44h36vmANVeLWLKlxYAELyh5HZVKOMBWuF r5N1D6TgWBSy7QHNjbXIbHp8RSVYQklEOFOMi2kEi6C2ooE9T_DCkJeLfQ1sqOOa.C3ldt879zth BLDkYt60vb2yW4qD8RulumpD06ZyrtLH56_S01Nsz53hZ5h7XdKDEy2WElEpeU_kBackWuuyEzjj xdplvLrqiMiv1Gdp44FVrdGVnG1wGoG0mt5vHxoi4rR7XPiw9yO376LniaUjffMwrwXpv2wHGKQk I4fNNw7uKDurpinjbwV4dO6cEPXCsy_32I5oN9oRC_ip25etBNp92hfGbx2BKKqKXavNtqn5VKK3 RfolDufd5eX.VZ1_edAJPJnvM4epFwLvadpe1yPNhY_UMyj8eBNbJJFc6XG5tPRCCT.wHZbYobEF EQpUEiC2.aW28K98Ng2xQsQPDe5Bv7JZuoF1N85Q- X-Sonic-MF: X-Sonic-ID: 8524f183-0736-4754-bbb4-9b1a99084d9e Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Tue, 5 Dec 2023 17:57:01 +0000 Date: Tue, 5 Dec 2023 17:57:00 +0000 (UTC) From: Hannes Domani To: "gdb-patches@sourceware.org" Message-ID: <33555219.701451.1701799020946@mail.yahoo.com> In-Reply-To: <20231121164241.302-1-ssbssa@yahoo.de> References: <20231121164241.302-1-ssbssa.ref@yahoo.de> <20231121164241.302-1-ssbssa@yahoo.de> Subject: Re: [PATCH v3] Fix hardware watchpoints in replay mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21943 YMailNorrin X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. Am Dienstag, 21. November 2023, 17:43:23 MEZ hat Hannes Domani Folgendes geschrieben: > Changes introduced by commit 9e8915c6cee5c37637521b424d723e990e06d597 > caused a regression that meant hardware watchpoint stops would not > trigger in reverse execution or replay mode.=C2=A0 This was documented in > PR breakpoints/21969. > The problem is that record_check_stopped_by_breakpoint always overwrites > record_full_stop_reason, thus loosing the TARGET_STOPPED_BY_WATCHPOINT > value which would be checked afterwards. > > This commit fixes that by not overwriting the stop-reason in > record_full_stop_reason if we're not stopped at a breakpoint. > > And the test for hw watchpoints in gdb.reverse/watch-reverse.exp actually > tested sw watchpoints again, since "set can-use-hw-watchpoints 1" > doesn't convert enabled watchpoints to use hardware. > This is fixed by disabling said watchpoint while enabling hw watchpoints. > The same is not done for gdb.reverse/watch-precsave.exp, since it's not > possible to use hw watchpoints in restored recordings anyways. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D21969 > --- > gdb/record.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 1 - > gdb/testsuite/gdb.reverse/watch-reverse.exp | 4 ++++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/record.c b/gdb/record.c > index f7c82665b05..88235e36da7 100644 > --- a/gdb/record.c > +++ b/gdb/record.c > @@ -248,7 +248,6 @@ record_check_stopped_by_breakpoint (const address_spa= ce *aspace, >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 1; >=C2=A0=C2=A0=C2=A0=C2=A0 } > > -=C2=A0 *reason =3D TARGET_STOPPED_BY_NO_REASON; >=C2=A0=C2=A0 return 0; > } > > diff --git a/gdb/testsuite/gdb.reverse/watch-reverse.exp b/gdb/testsuite/= gdb.reverse/watch-reverse.exp > index 6b81a6fdf88..a7126ac9b1d 100644 > --- a/gdb/testsuite/gdb.reverse/watch-reverse.exp > +++ b/gdb/testsuite/gdb.reverse/watch-reverse.exp > @@ -118,8 +118,12 @@ gdb_test "continue" \ >=C2=A0=C2=A0=C2=A0=C2=A0 ".*\[Ww\]atchpoint.*ival3.*Old value =3D 0.*New v= alue =3D -1.*ival3 =3D count; ival4 =3D count;.*" \ >=C2=A0=C2=A0=C2=A0=C2=A0 "watchpoint hit in reverse, fifth time" > > +gdb_test_no_output "disable \$bpnum" "disable non-hw watchpoint" > + > gdb_test_no_output "set can-use-hw-watchpoints 1" "enable hw watchpoints" > > +gdb_test_no_output "enable \$bpnum" "enable hw watchpoint" > + > ### > ### > ### > -- > 2.35.1