From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 395123858D20 for ; Mon, 28 Feb 2022 19:58:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 395123858D20 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-exEN_B7iOx2OmHrpkcKZIg-1; Mon, 28 Feb 2022 14:57:59 -0500 X-MC-Unique: exEN_B7iOx2OmHrpkcKZIg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6928E1091DA1 for ; Mon, 28 Feb 2022 19:57:58 +0000 (UTC) Received: from [10.2.17.55] (unknown [10.2.17.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 23CBD68D92 for ; Mon, 28 Feb 2022 19:57:58 +0000 (UTC) Message-ID: <337376b8-74f4-8e09-81c7-88452ba656e9@redhat.com> Date: Mon, 28 Feb 2022 11:57:56 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Fix "spawn id XYZ not open" errors in gdb.mi/mi-exec-run.exp To: gdb-patches@sourceware.org References: <20220224174113.1620498-1-keiths@redhat.com> <87k0dezykj.fsf@redhat.com> From: Keith Seitz In-Reply-To: <87k0dezykj.fsf@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 19:58:02 -0000 On 2/28/22 09:32, Andrew Burgess wrote: > Keith Seitz via Gdb-patches writes: > >> [1] Anyone know why this test doesn't simply use gdb_test_multiple? I can only >> assume that it was intentionally written this way, and I've modified the code with >> that assumption. I have tested a version using gdb_test_multiple, and that appears >> to work fine, too, if that is preferred. [It still employs exp_continue to fix the >> spawn_id errors.] > > As the reasoning isn't discussed in the .exp file, the commit message, > or in the original mailing list thread, I'd assume it was just an > oversight. If you see the same pass/fail using the gdb_test_multiple, > then I think it woud be a nice cleanup to switch over. I've tried testing this a bit more, and it looks like gdb_test_multiple "interferes" with the testing because of all the built-in matches. So we see "spurious" (as far as this test is concerned) "Process no longer exists" errors, and these end up racy between runs. So in that case, I will retract the gdb_test_multiple bit. I wonder if this was discussed this on IRC in the distant past? Thanks for the review! Keith