public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@arm.com>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>,
	John Baldwin <jhb@FreeBSD.org>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [Ping] [PATCH 0/4] Add AMX support.
Date: Wed, 25 May 2022 10:41:49 +0100	[thread overview]
Message-ID: <3379f03d-4a3d-8da8-5548-3ffc321cf78f@arm.com> (raw)
In-Reply-To: <MN2PR11MB4566EA9BBDA65EDC73DFF87D8ED69@MN2PR11MB4566.namprd11.prod.outlook.com>

On 5/25/22 10:14, Willgerodt, Felix via Gdb-patches wrote:
>> -----Original Message-----
>> From: John Baldwin <jhb@FreeBSD.org>
>> Sent: Freitag, 20. Mai 2022 18:29
>> To: Willgerodt, Felix <felix.willgerodt@intel.com>; gdb-
>> patches@sourceware.org
>> Subject: Re: [Ping] [PATCH 0/4] Add AMX support.
>>
>> On 5/20/22 7:40 AM, Willgerodt, Felix via Gdb-patches wrote:
>>> *Ping*
>>>
>>> I have adapted all of Eli's comments on documentation locally.
>>> They were all straightforward, so I didn't post a v2 for those yet.
>>
>> I don't have any further feedback.  I will say that I think it's fine to not
>> support dynamic tile sizes.  I think the aarch64 arch in GDB uses the same
>> approach with respect to SVE which is to say that the SVE vector size
>> is fixed for a given process' lifetime (or something along those lines).
>>
> 
> I couldn't try SVE myself, but it seems like SVE is actually updated at each
> BP, at least for native Linux GDB targets,
> see aarch64_linux_nat_target::thread_architecture().
> 
> We tried implementing it that way as well, but the gdbserver
> infrastructure to handle target description updates doesn't really exist.

That is the main barrier for supporting vector/matrix length updates mid-execution for remote targets.

There was some early discussions here: https://sourceware.org/pipermail/gdb/2020-January/048274.html

But there wasn't much consensus on the best way to do it.

Ideally we'd have a proper sizeless type to describe the scalable vector/matrix, based on a dynamic
property (a register, for example). But that requires many more changes.

> 
> That said, I don't think a fixed AMX dimension would provide a good
> user experience though. Neither in the case of showing the whole
> register nor when using a fixed dimension for a process' lifetime.> 
> Regards,
> Felix
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928


  reply	other threads:[~2022-05-25  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 14:40 Willgerodt, Felix
2022-05-20 16:29 ` John Baldwin
2022-05-25  9:14   ` Willgerodt, Felix
2022-05-25  9:41     ` Luis Machado [this message]
2022-05-25  9:35   ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3379f03d-4a3d-8da8-5548-3ffc321cf78f@arm.com \
    --to=luis.machado@arm.com \
    --cc=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).