From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99636 invoked by alias); 22 Nov 2017 11:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99625 invoked by uid 89); 22 Nov 2017 11:14:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=touching, super X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 11:14:21 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F44E37E8E; Wed, 22 Nov 2017 11:14:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A10060CA2; Wed, 22 Nov 2017 11:14:19 +0000 (UTC) Subject: Re: [RFA 00/13] Makefile simplifications and subdirification To: Tom Tromey , gdb-patches@sourceware.org References: <20171121221023.23992-1-tom@tromey.com> From: Pedro Alves Message-ID: <338257c4-3c6e-9d08-a482-5fd2cd36e1fb@redhat.com> Date: Wed, 22 Nov 2017 11:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171121221023.23992-1-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00484.txt.bz2 On 11/21/2017 10:10 PM, Tom Tromey wrote: > This is a follow-on to Yao's earlier patch to move some object files > to subdirectories. > > This first changes the approach to making such subdirectories, to make > it simpler on subsequent patches. Then it moves object files to > subdirs, removing hand-maintained lists of .o files in favor of > patsubst, following the "don't repeat yourself" principle. > > The last patches apply similar cleanups more generically. The net > result is the removal of many redundant lines of code. > > I did not touch common/ in this series. I started this, but due to > commmon/common.host, a change here would require touching gdbserver as > well, which I did not want to do. > > I think there are more cleanups available to be done; I just did not > do them. A good end goal, I think, would be to make it so that only > source files are explicitly named in the Makefile, with the > intermediate names being generated from the source lists. This would > make adding new source files much simpler. > > Tested by rebuilding. I also did a build with > --disable-{python,guile,tui,gdbmi} (did you know you can disable MI?). > You may need to do a clean build if this lands; though I am not > completely certain. This is super. Thanks so much for doing this. I read the whole series, and patches I didn't comment on looks good to me as is. Thanks, Pedro Alves