From: Simon Marchi <simon.marchi@polymtl.ca>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH] Fix error message and use-after-free on errors in nested source files
Date: Wed, 20 Feb 2019 02:16:00 -0000 [thread overview]
Message-ID: <3385e948-564c-4f75-1a77-b488869a1819@polymtl.ca> (raw)
In-Reply-To: <20190219165130.67e94f6a@f29-4.lan>
On 2019-02-19 6:51 p.m., Kevin Buettner wrote:
> On Tue, 19 Feb 2019 23:24:01 +0000
> Simon Marchi <simon.marchi@ericsson.com> wrote:
>
>>> Did you mean to remove gdb_exit above? If so, why?
>>
>> Yes, many tests have a gdb_exit at the end. I believe this is not necessary (though it doesn't hurt)
>> because it's done anyway after the execution of the test. So it has become an automatism to remove
>> it if I am modifying that area of the tests. I can leave it there if you prefer.
>
> Thanks for the explanation.
>
>> Thanks for the review, here's the updated version. I also fixed the title,
>> where it should read "sourced" instead of "source".
>
> LGTM.
>
> Kevin
>
Thanks, I pushed it.
Simon
prev parent reply other threads:[~2019-02-20 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 23:46 Simon Marchi
2019-02-19 22:37 ` Kevin Buettner
2019-02-19 23:25 ` Simon Marchi
2019-02-19 23:51 ` Kevin Buettner
2019-02-20 2:16 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3385e948-564c-4f75-1a77-b488869a1819@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).