From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix crash in is_nocall_function
Date: Sun, 11 Dec 2022 21:45:35 -0500 [thread overview]
Message-ID: <33a01faa-769a-cfcd-8d2d-c1d557c0f14f@simark.ca> (raw)
In-Reply-To: <20221211195331.252485-1-tom@tromey.com>
> diff --git a/gdb/testsuite/gdb.base/exprs.exp b/gdb/testsuite/gdb.base/exprs.exp
> index 5bf03bf1320..b8698880339 100644
> --- a/gdb/testsuite/gdb.base/exprs.exp
> +++ b/gdb/testsuite/gdb.base/exprs.exp
> @@ -271,3 +271,7 @@ gdb_test "print & (void) v_char" "value not located in memory."
> # Regression test for "&&".
> gdb_test "print null_t_struct && null_t_struct->v_int_member == 0" \
> " = 0"
> +
> +# Regression test for unusual function-call parse that caused a crash.
> +gdb_test "print v_short++ (97)" \
> + "cast the call to its declared return type"
To avoid the trailing parenthesis to be considered not in the test name,
either remove the space, or give an explicit name to the test.
Otherwise, LGTM:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2022-12-12 2:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 19:53 Tom Tromey
2022-12-12 2:45 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a01faa-769a-cfcd-8d2d-c1d557c0f14f@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).