From: Zied Guermazi <zied.guermazi@trande.de>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/1] get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE
Date: Fri, 29 Apr 2022 17:38:11 +0200 [thread overview]
Message-ID: <33c69c1d-7153-9cb0-ae77-f2a560927ea6@trande.de> (raw)
In-Reply-To: <96f68c7d-9887-1a90-060c-e8f5afdc0103@palves.net>
Hi Pedro,
No issue, I will update the patch accordingly.
/Zied
On 28.04.22 18:14, Pedro Alves wrote:
> On 2022-04-28 12:50, Zied Guermazi wrote:
>> + if (page_size == -1)
>> + perror_with_name (_("Failed to get system page size: %s"));
> Sorry, my fault here -- the ": %s" part shouldn't be there. You want just:
>
> perror_with_name (_("Failed to get system page size"));
>
> (I have not read the rest of the patch in any detail.)
--
prev parent reply other threads:[~2022-04-29 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:50 [PATCH v3 0/1] " Zied Guermazi
2022-04-28 11:50 ` [PATCH v3 1/1] " Zied Guermazi
2022-04-28 16:14 ` Pedro Alves
2022-04-29 15:38 ` Zied Guermazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33c69c1d-7153-9cb0-ae77-f2a560927ea6@trande.de \
--to=zied.guermazi@trande.de \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).