From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Basic c++ification of varobj
Date: Wed, 22 Nov 2017 10:44:00 -0000 [thread overview]
Message-ID: <33fb6307-b3ad-83c3-9f24-e644856d4171@redhat.com> (raw)
In-Reply-To: <20171118214606.24468-2-simon.marchi@polymtl.ca>
On 11/18/2017 09:46 PM, Simon Marchi wrote:
> /* Return the type of the value that's stored in VAR,
> diff --git a/gdb/varobj.h b/gdb/varobj.h
> index 0d4a537d7e..d09b99b7f2 100644
> --- a/gdb/varobj.h
> +++ b/gdb/varobj.h
> @@ -89,6 +89,9 @@ struct varobj_dynamic;
> a particular object variable. */
> struct varobj
> {
> + varobj (varobj_root *root_);
explicit?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-11-22 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 21:46 [PATCH 0/4] C++ify varobj a little bit Simon Marchi
2017-11-18 21:46 ` [PATCH 4/4] Remove DEF_VEC_P (varobj_p) Simon Marchi
2017-11-18 21:46 ` [PATCH 2/4] Make varobj::children an std::vector Simon Marchi
2017-11-18 21:46 ` [PATCH 3/4] Replace VEC (varobj_update_result) with std::vector Simon Marchi
2017-11-18 21:57 ` [PATCH 1/4] Basic c++ification of varobj Simon Marchi
2017-11-21 21:31 ` Yao Qi
2017-11-22 20:04 ` Simon Marchi
2017-11-22 10:44 ` Pedro Alves [this message]
2017-11-22 20:05 ` Simon Marchi
2017-11-21 21:36 ` [PATCH 0/4] C++ify varobj a little bit Yao Qi
2017-11-22 20:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33fb6307-b3ad-83c3-9f24-e644856d4171@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).