From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89548 invoked by alias); 22 Nov 2017 10:44:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89530 invoked by uid 89); 22 Nov 2017 10:44:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*M:83c3, Hx-languages-length:433 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Nov 2017 10:44:05 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F16DA76542; Wed, 22 Nov 2017 10:44:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 570115D6A5; Wed, 22 Nov 2017 10:44:03 +0000 (UTC) Subject: Re: [PATCH 1/4] Basic c++ification of varobj To: Simon Marchi , gdb-patches@sourceware.org References: <20171118214606.24468-1-simon.marchi@polymtl.ca> <20171118214606.24468-2-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <33fb6307-b3ad-83c3-9f24-e644856d4171@redhat.com> Date: Wed, 22 Nov 2017 10:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171118214606.24468-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00481.txt.bz2 On 11/18/2017 09:46 PM, Simon Marchi wrote: > /* Return the type of the value that's stored in VAR, > diff --git a/gdb/varobj.h b/gdb/varobj.h > index 0d4a537d7e..d09b99b7f2 100644 > --- a/gdb/varobj.h > +++ b/gdb/varobj.h > @@ -89,6 +89,9 @@ struct varobj_dynamic; > a particular object variable. */ > struct varobj > { > + varobj (varobj_root *root_); explicit? Thanks, Pedro Alves