Re: [PATCH] [gdb] Add template functions assign_set/return_if_changed

[Tom de Vries <tdevries@suse.de>]

On 5/23/23 11:57, Lancelot SIX wrote:
> Hi Tom,
> 
>> I've initially considered using assign_return_if_changed for the rewrite:
>> ...
>> template<typename T>
>> bool
>> assign_return_if_changed (T &lval, T val)
>> {
>>    if (lval == val)
>>      return false;
>>
>>    lval = val;
>>    changed = true;
> 
> This line should be "return true" (only the commit comment is affected,
> the actual implementation is OK).
> 

Thanks for spotting that, I've updated my patch.

>> }
>> ...
>> but liked the resulting bitwise operator on the boolean a bit less:
>> ...
>>    need_redraw |= assign_return_if_changed<int> (tui_border_attrs, entry->value);
>> ...
> 
> I think I like it a bit more (not by far though), but I guess that is
> just a personal preference ^_^.
> 

Thanks for that feedback, that's good to know, and I'm curious about 
opinions of other as well.

- Tom

>>
>> I've included it anyway, it may be the preferred choice in other cases.
>>
> 
> Best,
> Lancelot.